Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRA-861: Fixed issue with reading xyz-surfaces in the case when area … #256

Merged
merged 1 commit into from
Mar 8, 2017

Conversation

hgolsen
Copy link
Member

@hgolsen hgolsen commented Feb 28, 2017

…is taken from surface.

@alfbr
Copy link
Member

alfbr commented Mar 7, 2017

Is this related to #254 or #255 ?

@hgolsen
Copy link
Member Author

hgolsen commented Mar 7, 2017

This is related to both. This is a general fix for reading xyz-surfaces, but tested on a simpler case. It is not certain that it fixes both these problems, so please re-run both cases when this pull-request is merged.

@alfbr
Copy link
Member

alfbr commented Mar 8, 2017

Great, already downloaded and compiled. Will try to get it tested over here.

@alfbr
Copy link
Member

alfbr commented Mar 8, 2017

PR tested. The inversion still fails, at the exact same location. This is the error message:

cravarun: ../libs/nrlib/surface/../grid/grid2d.hpp:147: size_t NRLib::Grid2D::GetIndex(size_t, size_t) const [with A = double]: Assertion `j < nj_' failed.

@hgolsen hgolsen merged commit d408d3f into CRAVA:master Mar 8, 2017
@hgolsen
Copy link
Member Author

hgolsen commented Mar 8, 2017

Sorry. This was not merged (this was only a request for merging), so you did not have the updates. (There is usually a small delay from when a request is made to when it is merged into the master branch.)

I have merged the commit into the master branch now. Can you test again tomorrow?

@alfbr
Copy link
Member

alfbr commented Mar 8, 2017

I am not completely ignorant ;-) I forked your repository, and double checked that this commit was in there before I compiled:

$ git log
commit 403f6c5
Author: Håvard Goodwin Olsen [email protected]
Date: Tue Feb 28 13:06:24 2017 +0100

CRA-861: Fixed issue with reading xyz-surfaces in the case when area is taken from surface.

@hgolsen
Copy link
Member Author

hgolsen commented Mar 8, 2017

Ah, okey :) I didn't think of that option. Then these issues are still unresolved.

@alfbr
Copy link
Member

alfbr commented Mar 8, 2017

Yes, I believe so. You have the datasets, so please see if you can reproduce at your end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants