Add a list of contributors to people page #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for crmodders ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Caveat: this is not a major issue, but this PR exacerbates the fact that we are making unauthenticated calls to the GH API, which can cause users to get rate limited if they refresh the page too much (ran into this just testing style/layout changes). This can be solved with some caching since the rate limit is by IP. I will fix this in another PR. |
realeatham
approved these changes
Apr 9, 2024
|
You should merge this |
Not until I implement a cache or some other workaround to keep people from rate limiting themselves on the GitHub API. That's why it's a draft PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This queries GitHub for a list of repos created by CRM (excluding forks) and gets the contributors to those repos. It then sorts that list by number of contributions, and features the top 10 contributors on the page. This helps people get a better idea of who has contributed to CRM projects :)