-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove mandatory and fixed parameters from queryables #1159
Draft
anesson-cs
wants to merge
4
commits into
develop
Choose a base branch
from
fixed-params-not-in-queryables
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage (Ubuntu)
Diff against develop
Results for commit: 2cb5ff0 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Code Coverage (Windows)
Diff against develop
Results for commit: 2cb5ff0 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
anesson-cs
force-pushed
the
fixed-params-not-in-queryables
branch
2 times, most recently
from
May 24, 2024 18:03
b328f2c
to
de86927
Compare
…n eodag configuration
…ders with qssearch search plugin
anesson-cs
force-pushed
the
fixed-params-not-in-queryables
branch
from
August 2, 2024 15:32
de86927
to
2cb5ff0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Among default parameters of a product type in a provider configuration, some may be mandatory and fixed. Then they are not queryable anymore and we remove them from the returned queryables in
discover_queryables()
method at search plugin level.It works by using the keyword
remove_from_queryables
in providers search configuration.We list unwanted queryables for all product types of the provider in a list called
shared_queryables
and product type-specific unwanted queryables are in the list called by the name of the product type.