-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1371 update wekeo configuration following api changes #1392
Open
amarandon
wants to merge
5
commits into
develop
Choose a base branch
from
1371-update-wekeo-configuration-following-api-changes
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
1371 update wekeo configuration following api changes #1392
amarandon
wants to merge
5
commits into
develop
from
1371-update-wekeo-configuration-following-api-changes
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
amarandon
commented
Nov 7, 2024
•
edited
Loading
edited
- mission start date had month and day swapped
- fire_danger_index is now fire_weather_index
- format has become data_format
- data_format expects a single string and not list
Code Coverage (Ubuntu)
Diff against develop
Results for commit: 9b0ed7d Minimum allowed coverage is ♻️ This comment has been updated with latest results |
amarandon
force-pushed
the
1371-update-wekeo-configuration-following-api-changes
branch
from
November 7, 2024 14:24
86ccd7e
to
5e75e7a
Compare
Code Coverage (Windows)
Diff against develop
Results for commit: 9b0ed7d Minimum allowed coverage is ♻️ This comment has been updated with latest results |
amarandon
commented
Nov 7, 2024
jlahovnik
reviewed
Nov 7, 2024
You can remove the note from the PR description. |
jlahovnik
requested changes
Nov 8, 2024
FIRE_HISTORICAL has been removed from cop_cds and moved to cop_ewds.
amarandon
force-pushed
the
1371-update-wekeo-configuration-following-api-changes
branch
from
November 8, 2024 15:28
0c7a820
to
9b0ed7d
Compare
jlahovnik
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.