Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

working judge0 api for code execution #45

Merged
merged 1 commit into from
Nov 3, 2024
Merged

Conversation

bhnuka
Copy link

@bhnuka bhnuka commented Nov 3, 2024

No description provided.

Copy link

github-actions bot commented Nov 3, 2024

Frontend URL:
Backend URL:

Copy link

@sp4ce-cowboy sp4ce-cowboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor change regarding the type checking


import * as Y from 'yjs';
import { WebsocketProvider } from 'y-websocket';

// @ts-check

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add this line back, it's not a comment but actually a macro (?) to force type-checking. This is because CodemirrorBinding is typeless in javascript, and we want to use it in a typed context like TypeScript

@sp4ce-cowboy sp4ce-cowboy merged commit 44bba38 into dev Nov 3, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants