-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add topics + Add question duplication check when updating qn #61
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
edad89d
update topics and sampledata
bhnuka 9fe3f0f
add error handling for duplicate edits (based off title name)
bhnuka a1036c1
remove databses since sql languages not supported by collab service
bhnuka 983c143
after failed edit, set back to add a new qn
bhnuka 8e61170
add duplicate title error message
bhnuka 6f9cccb
add normalisation to lowercase
bhnuka 0dab06d
add middleware
bhnuka 8ffed12
add functionality to see what difficulties and categories are current…
bhnuka 15b803e
Merge branch 'dev' into add-topics
bhnuka 588485d
Merge branch 'dev' into add-topics
bhnuka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
peerprep/backend/question-service/src/middleware/normalizationMiddleware.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
import { Request, Response, NextFunction } from 'express'; | ||
|
||
export const normalizeQuestionData = (req: Request, res: Response, next: NextFunction): void => { | ||
if (req.body) { | ||
if (Array.isArray(req.body.categories)) { | ||
req.body.categories = req.body.categories.map((cat: string) => cat.toLowerCase()); | ||
} | ||
if (typeof req.body.difficulty === 'string') { | ||
req.body.difficulty = req.body.difficulty.toLowerCase(); | ||
} | ||
} | ||
next(); | ||
}; |
6 changes: 5 additions & 1 deletion
6
peerprep/backend/question-service/src/routes/questionRoutes.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,19 @@ | ||
import { Router } from 'express'; | ||
import { getQuestions, getQuestionById, createQuestion, updateQuestion, deleteQuestion, getRandomQuestionEndpoint } from '../controllers/questionController'; | ||
import { getQuestions, getQuestionById, createQuestion, updateQuestion, deleteQuestion, getRandomQuestionEndpoint, getAllCategories, getAllDifficulties, checkCategoryDifficultyAvailability } from '../controllers/questionController'; | ||
|
||
const router: Router = Router(); | ||
|
||
// Define routes for CRUD operations | ||
router.get('/questions/random-question', getRandomQuestionEndpoint); | ||
router.get('/questions', getQuestions); | ||
router.get('/questions/:id', getQuestionById); | ||
router.get('/categories', getAllCategories); | ||
router.get('/difficulties', getAllDifficulties); | ||
router.get('/availability', checkCategoryDifficultyAvailability); | ||
router.post('/questions', createQuestion); | ||
router.put('/questions/:id', updateQuestion); | ||
router.delete('/questions/:id', deleteQuestion); | ||
|
||
|
||
|
||
export default router; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!