Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View completed sessions #203

Merged
merged 43 commits into from
Nov 8, 2024
Merged

View completed sessions #203

merged 43 commits into from
Nov 8, 2024

Conversation

yunruu
Copy link

@yunruu yunruu commented Nov 7, 2024 •
edited
Loading

Features

  • Add view icon in action column in sessions datatable
  • Route to code page in View Only mode for completed sessions
  • Disable all editables in View Only mode (including chat, code editor, language mode switch)

Resolves

@netlify Netlify
Copy link

netlify bot commented Nov 7, 2024 •
edited
Loading

✅ Deploy Preview for peerprep-g31 ready!

Name Link
🔨 Latest commit 78b5d12
🔍 Latest deploy log https://app.netlify.com/sites/peerprep-g31/deploys/672dbc14dac3d60008311495
😎 Deploy Preview https://deploy-preview-203--peerprep-g31.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yunruu yunruu marked this pull request as draft November 7, 2024 09:54
glemenneo and others added 22 commits November 7, 2024 18:11
@glemenneo @yunruu
[#196] fix: change websocket servers to be env variables
177fd4d
@glemenneo @yunruu
[#196] fix: add proxy pass for websocket ports
636f02b
@glemenneo @yunruu
[#196] fix: change websocket url nullish coalesing to properly append…
93cc752 
… suffix
@glemenneo @yunruu
[#196] fix: remove hardcoded url and add properly suffixed ws url to …
d471ab8 
…route to proxy pass
@glemenneo @yunruu
[#196] refactor: remove redundant console log
ce413ff
@yunruu
Handle no question
29f8387
@Daviancold @yunruu
fix: add missing import
2c7cab6
@Daviancold @yunruu
ci: add required package for FE CI/CD
b1b62c7
@Daviancold @yunruu
fix: missing submission type import
c9ee5df
@Daviancold @yunruu
ci: update lock file
49ed154
@Daviancold @yunruu
ci: add config to debug deployment
20ebdf5
@Daviancold @yunruu
add: netlify.toml
d152b3f
@Daviancold @yunruu
refactor: move toml file
63695e0
@Daviancold @yunruu
ci: testing toml changes
316f60f
@Daviancold @yunruu
ci: toml update
c5a5144
@Daviancold @yunruu
ci: rename toml temporarily to prevent use from deployment
f983c5e
@yunruu
fix: display toast instead of routing user to home if error retrievin…
ab000b2 
…g chat
@yunruu
refactor: return match res data and show error toast if any
764055a
@Daviancold @yunruu
feat: refactor handling logic for match and session creation in front…
ac1bbd6 
…end and backend

Co-authored-by: Chin Yun Ru <[email protected]>
@Daviancold @yunruu
fix: unprotected post route
17b3437
@Daviancold @yunruu
fix: typo in mq service
2b4bcfb
@yunruu
refactor: log errors in match and session creation
39535f3
@yunruu yunruu changed the title Add action panel to view previous sessions View previous sessions Nov 7, 2024
@yunruu yunruu changed the title View previous sessions View completed sessions Nov 7, 2024
@yunruu yunruu marked this pull request as ready for review November 7, 2024 14:28
@Daviancold
Copy link

After both users exit from the session, the session no longer terminates and is still resumable. Can I check if this is intended?

@yunruu
Copy link
Author

yunruu commented Nov 8, 2024

After both users exit from the session, the session no longer terminates and is still resumable. Can I check if this is intended?

I believe it might be a CORS error, from docker testing there does not seem to have such an issue. Could you try testing with compose?

Daviancold
Daviancold approved these changes Nov 8, 2024
View reviewed changes
Copy link

@Daviancold Daviancold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yunruu yunruu merged commit 04b3708 into main Nov 8, 2024
9 checks passed
This was linked to issues Nov 8, 2024
[FE] [Collaboration Service] Session history page integration with collaboration service (Session re-entry logic) #138
Closed
[FE] Show previous sessions in dashboard #204
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Daviancold Daviancold Daviancold approved these changes

@shishirbychapur shishirbychapur Awaiting requested review from shishirbychapur shishirbychapur is a code owner

@glemenneo glemenneo Awaiting requested review from glemenneo glemenneo is a code owner

@lynnlow175 lynnlow175 Awaiting requested review from lynnlow175 lynnlow175 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@yunruu @Daviancold @glemenneo