Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance visual and user experience #214

Merged
merged 13 commits into from
Nov 13, 2024

Conversation

yunruu
Copy link

@yunruu yunruu commented Nov 10, 2024

New features

  • Lighten button focus color
  • Even out columns spacing in questions data table
  • Show info toast when session ends
  • Show success toast on question delete
  • Show more specific dialog header
  • Encode match id in url for security reasons

@yunruu yunruu self-assigned this Nov 10, 2024
@yunruu yunruu linked an issue Nov 10, 2024 that may be closed by this pull request
Copy link

netlify bot commented Nov 10, 2024

Deploy Preview for peerprep-g31 ready!

Name Link
🔨 Latest commit 6d5eca7
🔍 Latest deploy log https://app.netlify.com/sites/peerprep-g31/deploys/673478d99feb1600085ca941
😎 Deploy Preview https://deploy-preview-214--peerprep-g31.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shishirbychapur
Copy link

refreshing during the session causes this error

Unhandled Runtime Error
InvalidCharacterError: Failed to execute 'atob' on 'Window': The string to be decoded is not correctly encoded.

Source
util\encryption.ts (6:12) @ atob

4 |
5 | export const decodeStr = (encoded: string) => {

6 | return atob(encoded)
| ^
7 | }
8 |

Better to just remove the encoding part i feel

@yunruu
Copy link
Author

yunruu commented Nov 13, 2024

refreshing during the session causes this error

Unhandled Runtime Error InvalidCharacterError: Failed to execute 'atob' on 'Window': The string to be decoded is not correctly encoded.

Source util\encryption.ts (6:12) @ atob

4 | 5 | export const decodeStr = (encoded: string) => {

6 | return atob(encoded)
| ^
7 | }
8 |

Better to just remove the encoding part i feel

Good catch, issue has been fixed, it is caused by undefined router id on initial load. I think we should implement it as it's just better security practice 😄

Copy link

@Daviancold Daviancold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm, feedback given directly and edited

@yunruu yunruu merged commit 0dc80cd into main Nov 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FE] Visual and user experience enhancements
4 participants