New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix install #32

Open

ax487 wants to merge 2 commits into CSCsw:master from ax487:fix-install

ax487 commented Oct 28, 2019

As was pointed out in #29, the install directories are not set in a fashion consistent with well-established standards:

Libraries should go into /lib and not in /lib/ColPack_static
Cmake configurations must go into /lib/cmake/ColPack in order
for cmake to be able to find them.
Exported targes should be namespace'd

Also, the includes for the installed files
https://github.com/CSCsw/ColPack/blob/master/build/cmake/CMakeLists.txt#L134-L135
and the location of the installed includes
https://github.com/CSCsw/ColPack/blob/master/build/cmake/CMakeLists.txt#L173
must coincide. Otherwise exporting targets becomes rather pointless.

This request contains fixes to all of these issues. As a result, a simple example project of the form

find_package(ColPack REQUIRED)
target_link_libraries(<example app> ColPack::ColPack_shared)

actually compiles :)

ax487 added 2 commits

October 28, 2019 12:57


          Fix install on linux

70e0b83


          Added namespaces to exported targets

f239566

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet