Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Related to #348 SSVC1.0.1 additions. #350

Open
wants to merge 7 commits into
base: feature-144-SSVC
Choose a base branch
from

Conversation

sei-vsarvepalli
Copy link
Contributor

This should have the right files and fixes for #348

@ccoffin
Copy link
Collaborator

ccoffin commented Oct 4, 2024

I believe that "schema/docs/CVE_Record_Format_bundled.json" is an output file and shouldn't be updated. As long as "CVE_Record_Format.json" is updated to include an import of the ssvc schema in the imports directory, it should be ok and the bundled file will be created automatically.

@sei-vsarvepalli
Copy link
Contributor Author

I believe that "schema/docs/CVE_Record_Format_bundled.json" is an output file and shouldn't be updated. As long as "CVE_Record_Format.json" is updated to include an import of the ssvc schema in the imports directory, it should be ok and the bundled file will be created automatically.

It looks like all the _bundled.json file that are created are the following.

  1. CVE_Record_Format_bundled_cnaPublishedContainer.json
  2. CVE_Record_Format_bundled_cnaRejectedContainer.json
  3. CVE_Record_Format_bundled_adpContainer.json

for(let t of ['cnaPublishedContainer', 'cnaRejectedContainer', 'adpContainer']) {
var subSchema = {
"$schema": "http://json-schema.org/draft-07/schema#",
"$id": `https://cveproject.github.io/cve-schema/schema/docs/CVE_Record_Format_bundled_${t}.json`,

The docs/CVE_Record_Format.json is created but it is not copied over to docs/CVE_Record_Format_bundled.json - at least not in the workflow file itself, so I just manually created it. We can fix the workflow file too, if that is preferred so all of this can be automated.

Also as seen in the log file for workflow

CVE_Record_Format.json created
CVE_Record_Format_bundled_adpContainer.json created
CVE_Record_Format_bundled_cnaRejectedContainer.json created
CVE_Record_Format_bundled_cnaPublishedContainer.json created

@ccoffin
Copy link
Collaborator

ccoffin commented Oct 7, 2024

Looks like i made a mistake when updating the schema-bundle.js a few months ago. 'CVE_Record_Format.json' should have been 'CVE_Record_Format_bundled.json.' I just made this fix in the develop branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants