[wip] Add documentation on mixture cure models #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Concerningly, in order to get the generic mixture cure model to work with the WeibullFitter, I had to scale the time inputs. I didn't have to do this in the custom crafted mixture cure model earlier in the documnentation. I'm still looking into this. |
|
I figured out what was going on with the scaling. If you're willing to accept PR #960 then I can remove the scaling. |
|
This looks good, but rereading what I previously wrote, I think I spend too much time on silly examples. If you agree, feel free to delete/rewrite parts, specifically to get people to reading about |
|
Will do. Sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to add additional documentation around mixture cure models.