Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolved typos, awaiting for approval #133

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

resolved typos, awaiting for approval #133

wants to merge 19 commits into from

Conversation

LZDXN
Copy link

@LZDXN LZDXN commented Jan 17, 2024

No description provided.

@CambioML
Copy link
Owner

CambioML commented Jan 18, 2024 •
edited
Loading

Based on https://google.github.io/styleguide/pyguide.html#310-strings, prefer """ for multi-line strings.

You should only use """ for multi lines instead of changing all single line to use """.

@LZDXN LZDXN changed the title modified most of the "s to triple " revert invalid """ to " Jan 19, 2024
goldmermaid
goldmermaid reviewed Jan 19, 2024
View reviewed changes
uniflow/flow/client.py Outdated Show resolved Hide resolved
goldmermaid
goldmermaid reviewed Jan 19, 2024
View reviewed changes
tests/test_viz.py Outdated Show resolved Hide resolved
goldmermaid
goldmermaid reviewed Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@goldmermaid goldmermaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jupyter notebooks look good to me. the .py files need more changes.

uniflow/flow/flow.py Outdated Show resolved Hide resolved
uniflow/flow/flow_factory.py Outdated Show resolved Hide resolved
uniflow/flow/rater/__init__.py Outdated Show resolved Hide resolved
@notion-workspace Notion Workspace
Copy link

[Uniflow] Remove \n from instructions

@LZDXN LZDXN changed the title revert invalid """ to " formatting and final validation Jan 29, 2024
@LZDXN LZDXN changed the title formatting and final validation resolved typos, awaiting for approval Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goldmermaid goldmermaid goldmermaid left review comments

@CambioML CambioML CambioML left review comments

@SayaZhang SayaZhang Awaiting requested review from SayaZhang SayaZhang is a code owner

@CluckRookie CluckRookie Awaiting requested review from CluckRookie CluckRookie is a code owner

@SeisSerenata SeisSerenata Awaiting requested review from SeisSerenata SeisSerenata is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LZDXN @CambioML @goldmermaid