Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cohort to Program naming #196

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Cohort to Program naming #196

merged 1 commit into from
Nov 25, 2024

Conversation

CourtneyGosselin
Copy link
Member

@CourtneyGosselin CourtneyGosselin commented Nov 23, 2024 •
edited
Loading

Ticket(s)

Description

This PR makes it so that the data-portal uses program instead of cohort and works with the other microservices for the following PRs

Expected Behaviour

  • The portal should work as normal with cohort replaced with program

Types of Change(s)

  • 🪲 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)

Has it been tested for:

  • My change requires a change to the documentation (runbook and playwright)
  • I have updated the documentation accordingly
  • Prettier linter doesn't return errors
  • Production branch PR browser testing: Chrome, Firefox, Edge, etc.
  • Locally tested
  • Dev server tested
  • Production tested when merging into stable/production branch
  • Runbook tasks pass locally/on UHN-Dev
  • If visuals have changed, Runbook has been updated with new screenshots

@CourtneyGosselin
Cohort to Progam naming
ba0d074 
Signed-off-by: Courtney Gosselin <[email protected]>
@CourtneyGosselin CourtneyGosselin changed the title Cohort to Progam naming Cohort to Program naming Nov 23, 2024
OrdiNeu
OrdiNeu approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@OrdiNeu OrdiNeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me ✔️

@CourtneyGosselin CourtneyGosselin merged commit 32b9ead into develop Nov 25, 2024
3 checks passed
@CourtneyGosselin CourtneyGosselin deleted the bugfix/cohort-to-program branch November 25, 2024 18:02
@candigbot candigbot mentioned this pull request Nov 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrdiNeu OrdiNeu OrdiNeu approved these changes

@daisieh daisieh Awaiting requested review from daisieh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CourtneyGosselin @OrdiNeu