Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making various messages during setup more verbose #409

Closed

Conversation

naresh-kumar-babu
Copy link
Contributor

Partial Fix #388 .

@yaronkoren
Copy link
Member

@naresh-kumar-babu - I have to apologize, because I realize now that I don't remember - and can't figure out - which parts, if any, of the original patch (#371) have to do with making setup more verbose. A search on "verbose" and "-v" does not return anything meaningful. Maybe I misread the code before? I don't know. So perhaps this whole task should just be abandoned.

Now I'm curious, though: does adding a "-v" flag to the run-all.sh call have any impact? That script doesn't seem to have such a flag, as far as I can tell.

@naresh-kumar-babu
Copy link
Contributor Author

@naresh-kumar-babu - I have to apologize, because I realize now that I don't remember - and can't figure out - which parts, if any, of the original patch (#371) have to do with making setup more verbose. A search on "verbose" and "-v" does not return anything meaningful. Maybe I misread the code before? I don't know. So perhaps this whole task should just be abandoned.

Now I'm curious, though: does adding a "-v" flag to the run-all.sh call have any impact? That script doesn't seem to have such a flag, as far as I can tell.

Even I could not find any. I thought this would be the one. Closing this PR.

@yaronkoren
Copy link
Member

Okay, having looked more at the code, now I think I remember what this was about: it was just the addition of a few more "echo" calls, and making some of them longer - like changing "Starting job runner..." to "Starting job runner (in 10 seconds)...". Not really that important, but it is something.

@naresh-kumar-babu naresh-kumar-babu deleted the verbose branch July 4, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add relevant wikiteq branch changes to master
2 participants