feat: add data presence check for solution history #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewingjm
reviewed
Oct 23, 2024
| @@ -313,6 +315,72 @@ public TResponse Execute<TResponse>(OrganizationRequest request, string username | |||
| return (TResponse)this.Execute(request); | |||
| } | |||
|
|
|||
| /// <inheritdoc/> | |||
| public bool HasStartedSolutionHistoryRecords(ILogger logger) | |||
There was a problem hiding this comment.
The naming of this method doesn't seem to match what it is actually doing.
There was a problem hiding this comment.
@ewingjm refactored extended service method to better reflect its intent
| new ConditionExpression(Constants.SolutionHistory.Fields.Status, ConditionOperator.Equal, Constants.SolutionHistory.Statuses.Started), | ||
| }, | ||
| }, | ||
| }); |
There was a problem hiding this comment.
QueryByAttribute would be more concise here.
There was a problem hiding this comment.
@ewingjm replaced QueryExpression with QueryByAttribute
src/Capgemini.PowerApps.PackageDeployerTemplate/Adapters/CrmServiceAdapter.cs
Show resolved
Hide resolved
…tion history records
- update existing tests to use the execute multiple solution history mock
- refactor implementation to track original request indexes mapping to ensure returned responses are in the correct order index
- change path to include solution sub-directory to contain the managed solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This change introduces a wait and retry policy when setting the state of processes during solution deployment.
Approach
Introducing a wait and retry policy ensures that all active solution history records are completed before proceeding with the next deployment operations.
TODOs