Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A0-544: Alert backup preparation #320

Closed

Conversation

woocash2
Copy link
Contributor

@woocash2 woocash2 commented Aug 17, 2023

Adjust backup to be able to store not only units (UncheckedSignedUnit) but also objects of type Alert and Multisigned. This is implemented by introducing an enum BackupItem which consists of variants which corresponds to the above types.

There is a single receiver of BackupItem in backup::run_saving_mechanism. runway and alerter should both have a sender which leads to this receiver in backup.

Currently no saving mechanism is implemented for alerter, this pr only introduces the new structure of BackupItem and adjustments to backup and runway caused by it.

@github-actions
Copy link

Please make sure the following happened

  • Appropriate tests created
  • Infrastructure updated accordingly
  • Updated existing documentation
  • New documentation created
  • Version bumped if breaking changes

@woocash2 woocash2 changed the base branch from main to A0-2884-alerter-refactor August 17, 2023 12:39
@woocash2 woocash2 changed the base branch from A0-2884-alerter-refactor to main August 17, 2023 15:59
@woocash2 woocash2 changed the base branch from main to A0-2884-alerter-refactor August 17, 2023 15:59
@woocash2 woocash2 force-pushed the A0-544-initial-alert-backup branch 2 times, most recently from 4d9f19f to 149ab46 Compare August 18, 2023 07:46
@woocash2 woocash2 closed this Aug 18, 2023
@woocash2 woocash2 deleted the A0-544-initial-alert-backup branch August 28, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant