Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A0-2961: Improve logs about DAG #339

Merged
merged 10 commits into from
Sep 1, 2023
Merged

A0-2961: Improve logs about DAG #339

merged 10 commits into from
Sep 1, 2023

Conversation

ggawryal
Copy link
Contributor

@ggawryal ggawryal commented Aug 30, 2023 •
edited
Loading

This PR

  • adds short runway DAG status report
  • shortens missing coords log by compressing consecutive numbers into a single interval

For the latter, we could alternatively leave missing coords logging as it is (there were cases when we were missing all but just a few coords and the message was 30k chars long) or instead simply truncate it, loosing some information.

Changes log structure.

@github-actions
Copy link

Please make sure the following happened

  • Appropriate tests created
  • Infrastructure updated accordingly
  • Updated existing documentation
  • New documentation created
  • Version bumped if breaking changes

@ggawryal ggawryal changed the title A0-2961: Improve dag logs A0-2961: Improve logs about DAG Aug 30, 2023
deuszx
deuszx reviewed Aug 30, 2023
View reviewed changes
consensus/src/runway/mod.rs Outdated Show resolved Hide resolved
h4nsu
h4nsu approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@h4nsu h4nsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the behalf of all future instances of me-looking-into-logs: THANK YOU <3

deuszx
deuszx reviewed Aug 31, 2023
View reviewed changes
consensus/src/runway/mod.rs Outdated Show resolved Hide resolved
kostekIV
kostekIV reviewed Aug 31, 2023
View reviewed changes
consensus/src/runway/mod.rs Show resolved Hide resolved
consensus/src/runway/mod.rs Outdated Show resolved Hide resolved
consensus/src/runway/mod.rs Outdated Show resolved Hide resolved
consensus/src/units/store.rs Outdated Show resolved Hide resolved
consensus/src/runway/mod.rs Outdated Show resolved Hide resolved
kostekIV
kostekIV approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@kostekIV kostekIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits left

consensus/src/runway/mod.rs Outdated Show resolved Hide resolved
consensus/src/runway/mod.rs Outdated Show resolved Hide resolved
consensus/src/runway/mod.rs Outdated Show resolved Hide resolved
@ggawryal ggawryal merged commit 63441f6 into main Sep 1, 2023
10 checks passed
@ggawryal ggawryal deleted the a0-2961-improve-dag-logs branch September 1, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deuszx deuszx deuszx left review comments

@kostekIV kostekIV kostekIV approved these changes

@h4nsu h4nsu h4nsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ggawryal @h4nsu @kostekIV @deuszx