Skip to content

Commit

Permalink
L1-265: Remove the fee_calculation test (#1773)
Browse files Browse the repository at this point in the history
# Description

The fee_calculation test seems to:

1. Test configuration parameters of `pallet_transaction_payment`
2. Be flaky, possibly by design. What I mean by this (although I don't
claim to have proven this) is that we run it without controlling block
production, so we can't really guarantee a certain block occupancy,
because it might depend on number of CPUs, random timings, etc.

## Type of change

Please delete options that are not relevant.

- Bug fix (non-breaking change which fixes an issue)
  • Loading branch information
obrok authored Jul 1, 2024
1 parent fd00b61 commit 9d13437
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 173 deletions.
16 changes: 0 additions & 16 deletions .github/workflows/_run-e2e-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,22 +65,6 @@ jobs:
artifact-aleph-node-image: ${{ inputs.artifact-aleph-node-image }}
artifact-chain-bootstrapper-image: ${{ inputs.artifact-chain-bootstrapper-image }}

run-e2e-fee-calculation-test:
name: Run e2e fee calculation test
needs: [run-e2e-finalization-test]
runs-on: ubuntu-20.04
steps:
- name: Checkout source code
uses: actions/checkout@v4

- name: Run e2e test
uses: ./.github/actions/run-e2e-test
with:
test-case: fee_calculation
artifact-aleph-e2e-client-image: ${{ inputs.artifact-aleph-e2e-client-image }}
artifact-aleph-node-image: ${{ inputs.artifact-aleph-node-image }}
artifact-chain-bootstrapper-image: ${{ inputs.artifact-chain-bootstrapper-image }}

run-e2e-channeling-fee-test:
name: Run e2e channeling fee test
needs: [run-e2e-finalization-test]
Expand Down
155 changes: 0 additions & 155 deletions e2e-tests/src/test/fee.rs

This file was deleted.

2 changes: 0 additions & 2 deletions e2e-tests/src/test/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ pub use button_game::{
pub use electing_validators::authorities_are_staking;
pub use era_payout::era_payouts_calculated_correctly;
pub use era_validators::era_validators;
pub use fee::fee_calculation;
pub use finality_version::{
finality_version_change, schedule_doomed_version_change_and_verify_finalization_stopped,
schedule_version_change,
Expand All @@ -32,7 +31,6 @@ mod electing_validators;
mod emergency_finalizer;
mod era_payout;
mod era_validators;
mod fee;
mod finality_version;
mod finalization;
mod helpers;
Expand Down

0 comments on commit 9d13437

Please sign in to comment.