A0-3310: Tidy up double quotes (#1471)

# Description Removes unnecessary double quotes in the workflow files. Also, tidies up some variable names and make use of `${{ env.VAR }}` everywhere, for the consistency and security. ## Type of change Please review carefully. We cannot break deployment workflows. # Checklist: --------- Co-authored-by: Mikolaj Gasior <[email protected]>
Cardinal-Cryptography · Nov 11, 2023 · ec12db0 · ec12db0
1 parent 2affe99
commit ec12db0
Show file tree

Hide file tree

Showing 21 changed files with 132 additions and 130 deletions.
diff --git a/.github/actions/get-docker-image-names/action.yml b/.github/actions/get-docker-image-names/action.yml
@@ -56,14 +56,16 @@ runs:
     - name: Get node image names
       id: get-docker-image-names
       shell: bash
+      env:
+        COMMIT_SHA: ${{ steps.get-ref-properties.outputs.sha }}
+        COMMIT_TAG: ${{ steps.get-ref-properties.outputs.tag }}
+        ECR: ${{ inputs.ecr-repo }}
+        DOCKERHUB: ${{ inputs.dockerhub-repo }}
+      # yamllint disable rule:line-length
       run: |
-        commit_sha=${{ steps.get-ref-properties.outputs.sha }}
-        commit_tag=${{ steps.get-ref-properties.outputs.tag }}
-        ecr='${{ inputs.ecr-repo }}'
-        dockerhub='${{ inputs.dockerhub-repo }}'
-        echo "ecr-rc-image=${ecr}:${commit_sha}" >> $GITHUB_OUTPUT
-        echo "ecr-deploy-image=${ecr}:${commit_tag}" >> $GITHUB_OUTPUT
-        echo "dockerhub-testnet-image=${dockerhub}:testnet-${commit_tag}" >> $GITHUB_OUTPUT
-        echo "dockerhub-mainnet-image=${dockerhub}:mainnet-${commit_tag}" >> $GITHUB_OUTPUT
-        echo "dockerhub-testnet-latest-image=${dockerhub}:testnet-latest" >> $GITHUB_OUTPUT
-        echo "dockerhub-mainnet-latest-image=${dockerhub}:mainnet-latest" >> $GITHUB_OUTPUT
+        echo 'ecr-rc-image=${{ env.ECR }}:${{ env.COMMIT_SHA }}' >> $GITHUB_OUTPUT
+        echo 'ecr-deploy-image=${{ env.ECR }}:${{ env.COMMIT_TAG }}' >> $GITHUB_OUTPUT
+        echo 'dockerhub-testnet-image=${{ env.DOCKERHUB }}:testnet-${{ env.COMMIT_TAG }}' >> $GITHUB_OUTPUT
+        echo 'dockerhub-mainnet-image=${{ env.DOCKERHUB }}:mainnet-${{ env.COMMIT_TAG }}' >> $GITHUB_OUTPUT
+        echo 'dockerhub-testnet-latest-image=${{ env.DOCKERHUB }}:testnet-latest' >> $GITHUB_OUTPUT
+        echo 'dockerhub-mainnet-latest-image=${{ env.DOCKERHUB }}:mainnet-latest' >> $GITHUB_OUTPUT
diff --git a/.github/workflows/_build-and-push-pull-request-image-to-featurenets.yml b/.github/workflows/_build-and-push-pull-request-image-to-featurenets.yml
@@ -32,7 +32,7 @@ jobs:
           ls -alh target/release/
           ls -alh ./docker/
           docker build \
-            --tag ${{ vars.ECR_PUBLIC_REGISTRY }}feature-env-aleph-node:${{ env.IMAGE_TAG }} \
+            --tag '${{ vars.ECR_PUBLIC_REGISTRY }}feature-env-aleph-node:${{ env.IMAGE_TAG }}' \
             -f ./docker/Dockerfile .
 
       - name: Login to ECR
@@ -47,4 +47,4 @@ jobs:
           # yamllint disable-line rule:line-length
           IMAGE_TAG: fe-${{ steps.get-ref-properties.outputs.branch-name-for-argo-with-sha }}
         run: |
-          docker push ${{ vars.ECR_PUBLIC_REGISTRY }}feature-env-aleph-node:${{ env.IMAGE_TAG }}
+          docker push '${{ vars.ECR_PUBLIC_REGISTRY }}feature-env-aleph-node:${{ env.IMAGE_TAG }}'
diff --git a/.github/workflows/_build-liminal-node.yml b/.github/workflows/_build-liminal-node.yml
@@ -23,7 +23,7 @@ jobs:
 
       - name: Build test binary and runtime
         run: |
-          cargo build --release -p aleph-node --features "liminal"
+          cargo build --release -p aleph-node --features 'liminal'
 
       - name: Upload test binary to GH Artifacts
         uses: actions/upload-artifact@v2

diff --git a/.github/workflows/_check-excluded-packages.yml b/.github/workflows/_check-excluded-packages.yml
@@ -34,27 +34,30 @@ jobs:
           field: 'toolchain.channel'
 
       - name: Install prerequisites
+        env:
+          RUST_TOOLCHAIN: ${{ steps.aleph-client-toolchain-channel.outputs.value }}
+          RUST_CONTRACTS_TOOLCHAIN: ${{ steps.contracts-toolchain-channel.outputs.value }}
+        # yamllint disable rule:line-length
         run: |
-          RUST_TOOLCHAIN=${{ steps.aleph-client-toolchain-channel.outputs.value }}
-          RUST_CONTRACTS_TOOLCHAIN=${{ steps.contracts-toolchain-channel.outputs.value }}
-          rustup toolchain install ${RUST_TOOLCHAIN}
-          rustup toolchain install ${RUST_CONTRACTS_TOOLCHAIN}
-          rustup component add rust-src --toolchain ${RUST_CONTRACTS_TOOLCHAIN}
+          rustup toolchain install '${{ env.RUST_TOOLCHAIN }}'
+          rustup toolchain install '${{ env.RUST_CONTRACTS_TOOLCHAIN }}'
+          rustup component add rust-src --toolchain '${{ env.RUST_CONTRACTS_TOOLCHAIN }}'
 
-          mkdir -p /tmp/contracts_toolchain/$RUST_CONTRACTS_TOOLCHAIN/
-          mkdir -p /tmp/$RUST_TOOLCHAIN/
+          mkdir -p '/tmp/contracts_toolchain/${{ env.RUST_CONTRACTS_TOOLCHAIN }}/'
+          mkdir -p '/tmp/${{ env.RUST_TOOLCHAIN }}/'
 
           export WASM_BUILD_WORKSPACE_HINT=${PWD}
-          export CARGO_TARGET_DIR=/tmp/contracts_toolchain/$RUST_CONTRACTS_TOOLCHAIN/target/
+          export CARGO_TARGET_DIR='/tmp/contracts_toolchain/${{ env.RUST_CONTRACTS_TOOLCHAIN }}/target/'
 
-          cargo +${RUST_CONTRACTS_TOOLCHAIN} \
-            install --version $CARGO_CONTRACT_VERSION \
+          cargo '+${{ env.RUST_CONTRACTS_TOOLCHAIN }}' \
+            install --version '${{ env.CARGO_CONTRACT_VERSION }}' \
             --force --locked cargo-contract
 
-          export CARGO_TARGET_DIR=/tmp/$RUST_TOOLCHAIN/target/
+          export CARGO_TARGET_DIR='/tmp/${{ env.RUST_TOOLCHAIN }}/target/'
 
-          cargo +${RUST_TOOLCHAIN} \
+          cargo '+${{ env.RUST_TOOLCHAIN }}' \
             install aleph-zero-cargo-nono --locked
+        # yamllint enable rule:line-length
 
       - name: Check excluded packages
         env:
@@ -72,13 +75,13 @@ jobs:
           # a version bump
           #
           # cd baby-liminal-extension/
-          # ${CHECK}
-          # ${CHECK} --features ink
+          # ${{ env.CHECK }}
+          # ${{ env.CHECK }} --features ink
 
           cd poseidon/
-          ${CHECK}
-          ${CHECK} --features circuit
+          ${{ env.CHECK }}
+          ${{ env.CHECK }} --features circuit
 
           cd ../relations/ark/
-          ${CHECK}
-          ${CHECK} --features circuit
+          ${{ env.CHECK }}
+          ${{ env.CHECK }} --features circuit
diff --git a/.github/workflows/_check-runtime-determimism.yml b/.github/workflows/_check-runtime-determimism.yml
@@ -31,9 +31,9 @@ jobs:
           ARTIFACT: aleph_runtime.compact.compressed.wasm
           TARGET_DIR: target/production/wbuild/aleph-runtime
         run: |
-          mkdir -p "$TARGET_DIR"
-          mv "$ARTIFACT" "$TARGET_DIR"
-          sha256sum "$TARGET_DIR/$ARTIFACT" > checksum.sha256
+          mkdir -p '${{ env.TARGET_DIR }}'
+          mv '${{ env.ARTIFACT }}' '${{ env.TARGET_DIR }}'
+          sha256sum '${{ env.TARGET_DIR }}/${{ env.ARTIFACT }}' > checksum.sha256
           cargo clean
           cargo build --profile production -p aleph-runtime
           sha256sum -c checksum.sha256
diff --git a/.github/workflows/_check-vars-and-secrets.yml b/.github/workflows/_check-vars-and-secrets.yml
@@ -13,44 +13,44 @@ jobs:
       - name: Check vars
         run: |
           if [[ \
-            -z "${{ vars.ECR_PUBLIC_HOST }}" || \
-            -z "${{ vars.ECR_PUBLIC_REGISTRY }}" || \
-            -z "${{ vars.DOCKERHUB_ALEPH_NODE_REPO }}" || \
-            -z "${{ vars.ECR_ALEPH_NODE_REPO }}" || \
-            -z "${{ vars.KUSTOMIZE_VERSION }}"
+            -z '${{ vars.ECR_PUBLIC_HOST }}' || \
+            -z '${{ vars.ECR_PUBLIC_REGISTRY }}' || \
+            -z '${{ vars.DOCKERHUB_ALEPH_NODE_REPO }}' || \
+            -z '${{ vars.ECR_ALEPH_NODE_REPO }}' || \
+            -z '${{ vars.KUSTOMIZE_VERSION }}'
           ]]; then
-            echo "!!! Some repository variables are either missing or empty."
-            echo "!!! Please check either repository or organization settings."
+            echo '!!! Some repository variables are either missing or empty.'
+            echo '!!! Please check either repository or organization settings.'
             exit 1
           fi
 
       - name: Check secrets
         run: |
           if [[ \
-            -z "${{ secrets.ARGOCD_DEVNET_HOST }}" || \
-            -z "${{ secrets.ARGO_SYNC_USER_TOKEN }}" || \
-            -z "${{ secrets.AWS_DEVNET_ACCESS_KEY_ID }}" || \
-            -z "${{ secrets.AWS_DEVNET_SECRET_ACCESS_KEY }}" || \
-            -z "${{ secrets.AWS_MAINNET_ACCESS_KEY_ID }}" || \
-            -z "${{ secrets.AWS_MAINNET_SECRET_ACCESS_KEY }}" || \
-            -z "${{ secrets.AUTOCOMMIT_AUTHOR }}" || \
-            -z "${{ secrets.AUTOCOMMIT_EMAIL }}" || \
-            -z "${{ secrets.CI_DEVNET_S3BUCKET_NAME }}" || \
-            -z "${{ secrets.CI_MAINNET_S3BUCKET_NAME }}" || \
-            -z "${{ secrets.CI_GH_TOKEN }}" || \
-            -z "${{ secrets.CI_S3BUCKET_NAME }}" || \
-            -z "${{ secrets.DEVNET_KEYS_S3BUCKET_NAME }}" || \
-            -z "${{ secrets.FEATURENET_KEYS_S3BUCKET_NAME }}" || \
-            -z "${{ secrets.REPO_ARGOCD_APPS_NAME }}" || \
-            -z "${{ secrets.REPO_OPS_FEATURENETS_NAME }}" || \
-            -z "${{ secrets.REPO_FEATURENET_TEMPLATE_NAME }}" || \
-            -z "${{ secrets.SYNCAZF }}" || \
-            -z "${{ secrets.DOCKERHUB_PASSWORD }}" || \
-            -z "${{ secrets.DOCKERHUB_USERNAME }}" || \
-            -z "${{ secrets.SLACK_WEBHOOK_TRACK_APPLICATIONS }}" || \
-            -z "${{ secrets.SLACK_WEBHOOK_DEV_ONDUTY }}"
+            -z '${{ secrets.ARGOCD_DEVNET_HOST }}' || \
+            -z '${{ secrets.ARGO_SYNC_USER_TOKEN }}' || \
+            -z '${{ secrets.AWS_DEVNET_ACCESS_KEY_ID }}' || \
+            -z '${{ secrets.AWS_DEVNET_SECRET_ACCESS_KEY }}' || \
+            -z '${{ secrets.AWS_MAINNET_ACCESS_KEY_ID }}' || \
+            -z '${{ secrets.AWS_MAINNET_SECRET_ACCESS_KEY }}' || \
+            -z '${{ secrets.AUTOCOMMIT_AUTHOR }}' || \
+            -z '${{ secrets.AUTOCOMMIT_EMAIL }}' || \
+            -z '${{ secrets.CI_DEVNET_S3BUCKET_NAME }}' || \
+            -z '${{ secrets.CI_MAINNET_S3BUCKET_NAME }}' || \
+            -z '${{ secrets.CI_GH_TOKEN }}' || \
+            -z '${{ secrets.CI_S3BUCKET_NAME }}' || \
+            -z '${{ secrets.DEVNET_KEYS_S3BUCKET_NAME }}' || \
+            -z '${{ secrets.FEATURENET_KEYS_S3BUCKET_NAME }}' || \
+            -z '${{ secrets.REPO_ARGOCD_APPS_NAME }}' || \
+            -z '${{ secrets.REPO_OPS_FEATURENETS_NAME }}' || \
+            -z '${{ secrets.REPO_FEATURENET_TEMPLATE_NAME }}' || \
+            -z '${{ secrets.SYNCAZF }}' || \
+            -z '${{ secrets.DOCKERHUB_PASSWORD }}' || \
+            -z '${{ secrets.DOCKERHUB_USERNAME }}' || \
+            -z '${{ secrets.SLACK_WEBHOOK_TRACK_APPLICATIONS }}' || \
+            -z '${{ secrets.SLACK_WEBHOOK_DEV_ONDUTY }}'
           ]]; then
-            echo "!!! Some repository secrets are either missing or empty."
-            echo "!!! Please check either repository or organization settings."
+            echo '!!! Some repository secrets are either missing or empty.'
+            echo '!!! Please check either repository or organization settings.'
             exit 1
           fi
diff --git a/.github/workflows/_update-node-image-infra.yml b/.github/workflows/_update-node-image-infra.yml
@@ -18,8 +18,8 @@ jobs:
       - name: Validate action inputs
         shell: bash
         run: |
-          if [[ "${{ inputs.env }}" != 'testnet' && "${{ inputs.env }}" != 'mainnet' ]]; then
-            echo "Error: inputs.env should be either mainnet or testnet!"
+          if [[ '${{ inputs.env }}' != 'testnet' && '${{ inputs.env }}' != 'mainnet' ]]; then
+            echo 'Error: inputs.env should be either mainnet or testnet!'
             exit 1
           fi
 
@@ -59,7 +59,7 @@ jobs:
           # yamllint disable-line rule:line-length
           repository: ${{ steps.get-repo-owner.outputs.repo-owner }}/${{ secrets.REPO_ARGOCD_APPS_NAME }}
           token: ${{ secrets.CI_GH_TOKEN }}
-          path: "${{ secrets.REPO_ARGOCD_APPS_NAME }}"
+          path: ${{ secrets.REPO_ARGOCD_APPS_NAME }}
 
       - name: Init kustomize
         uses: imranismail/setup-kustomize@v2
@@ -96,4 +96,4 @@ jobs:
           author_email: ${{ secrets.AUTOCOMMIT_EMAIL }}
           message: "Update ${{ inputs.env }} aleph-node tag ${{ env.TAG }}"
           add: "*.yaml"
-          cwd: "${{ secrets.REPO_ARGOCD_APPS_NAME }}"
+          cwd: ${{ secrets.REPO_ARGOCD_APPS_NAME }}
diff --git a/.github/workflows/build-and-push-cliain.yml b/.github/workflows/build-and-push-cliain.yml
@@ -36,7 +36,7 @@ jobs:
 
       - name: Cargo | Build release binary
         run: |
-          if [[ ${{ matrix.runtime }} = 'liminal' ]]; then
+          if [[ '${{ matrix.runtime }}' = 'liminal' ]]; then
             FEATURES="--features liminal"
           fi
           cd ./bin/cliain && cargo build --release ${FEATURES}
@@ -76,13 +76,13 @@ jobs:
                steps.get-ref-properties.outputs.branch-name-flattened) ||
                matrix.runtime == 'liminal' && steps.get-ref-properties.outputs.sha }}
         run: |
-          docker build -t "${{ env.REGISTRY }}${{ env.IMAGE_NAME }}:${{ env.TAG }}" \
+          docker build -t '${{ env.REGISTRY }}${{ env.IMAGE_NAME }}:${{ env.TAG }}' \
             -f ./bin/cliain/Dockerfile ./bin/cliain
           if [[ \
-            "${{ github.event_name }}" == "workflow_dispatch" || \
-            "${{ github.event_name }}" == "push" \
+            '${{ github.event_name }}' == 'workflow_dispatch' || \
+            '${{ github.event_name }}' == 'push' \
           ]]; then
-             docker push "${{ env.REGISTRY }}${{ env.IMAGE_NAME }}:${{ env.TAG }}"
+             docker push '${{ env.REGISTRY }}${{ env.IMAGE_NAME }}:${{ env.TAG }}'
           fi
 
       - name: Configure AWS credentials for S3 AWS

diff --git a/.github/workflows/deploy-to-devnet.yml b/.github/workflows/deploy-to-devnet.yml
@@ -49,7 +49,7 @@ jobs:
         with:
           repository: Cardinal-Cryptography/${{ secrets.REPO_ARGOCD_APPS_NAME }}
           token: ${{ secrets.CI_GH_TOKEN }}
-          path: "${{ secrets.REPO_ARGOCD_APPS_NAME }}"
+          path: ${{ secrets.REPO_ARGOCD_APPS_NAME }}
 
       - name: Init kustomize
         uses: imranismail/setup-kustomize@v2
@@ -64,7 +64,7 @@ jobs:
       - name: Sync all validator's keystores from S3
         run: |
           #!/bin/bash
-          aws s3 cp s3://alephzero-devnet-eu-central-1-keys-bucket/data data --recursive
+          aws s3 cp s3://${{ secrets.DEVNET_KEYS_S3BUCKET_NAME }}/data data --recursive
           # rename validator paths
           declare -A \
             NAMES=([aleph-node-validator-0]=5D34dL5prEUaGNQtPPZ3yN5Y6BnkfXunKXXz6fo7ZJbLwRRH \
@@ -84,11 +84,10 @@ jobs:
       - name: Generate chainspec
         env:
           RELEASE_TAG: ${{ steps.vars.outputs.sha_short }}
-
         # yamllint disable rule:line-length
         run: |
           #!/bin/bash
-          aws s3 cp s3://alephzero-devnet-eu-central-1-keys-bucket/data data --recursive
+          aws s3 cp 's3://${{ secrets.DEVNET_KEYS_S3BUCKET_NAME }}/data' data --recursive
 
           # well-known accounts
           ALICE=5GrwvaEF5zXb26Fz9rcQpDWS57CtERHpNehXCPcNoHGKutQY
@@ -97,12 +96,12 @@ jobs:
           EVE=5HGjWAeFDfFCWPsjFQdVV2Msvz2XtMktvgocEZcCj68kUMaw
 
           docker run -i -v $(pwd)/data:/data --env RUST_BACKTRACE=1 --entrypoint \
-            "/usr/local/bin/aleph-node" ${{ vars.ECR_PUBLIC_REGISTRY }}aleph-node:${RELEASE_TAG} \
+            '/usr/local/bin/aleph-node' '${{ vars.ECR_PUBLIC_REGISTRY }}aleph-node:${{ env.RELEASE_TAG }}' \
             bootstrap-chain --raw --base-path /data --chain-id a0dnet1 \
             --account-ids 5D34dL5prEUaGNQtPPZ3yN5Y6BnkfXunKXXz6fo7ZJbLwRRH,5GBNeWRhZc2jXu7D55rBimKYDk8PGk8itRYFTPfC8RJLKG5o,5Dfis6XL8J2P6JHUnUtArnFWndn62SydeP8ee8sG2ky9nfm9,5F4H97f7nQovyrbiq4ZetaaviNwThSVcFobcA5aGab6167dK,5DiDShBWa1fQx6gLzpf3SFBhMinCoyvHM1BWjPNsmXS8hkrW,5EFb84yH9tpcFuiKUcsmdoF7xeeY3ajG1ZLQimxQoFt9HMKR,5DZLHESsfGrJ5YzT3HuRPXsSNb589xQ4Unubh1mYLodzKdVY,5GHJzqvG6tXnngCpG7B12qjUvbo5e4e9z8Xjidk3CQZHxTPZ,5CUnSsgAyLND3bxxnfNhgWXSe9Wn676JzLpGLgyJv858qhoX,5CVKn7HAZW1Ky4r7Vkgsr7VEW88C2sHgUNDiwHY9Ct2hjU8q \
             --sudo-account-id 5F4SvwaUEQubiqkPF8YnRfcN77cLsT2DfG4vFeQmSXNjR7hD \
             --rich-account-ids $ALICE,$BOB,$CHARLIE,$EVE > chainspec.json
-          aws s3 cp chainspec.json s3://alephzero-devnet-eu-central-1-keys-bucket/chainspec.json
+          aws s3 cp chainspec.json 's3://${{ secrets.DEVNET_KEYS_S3BUCKET_NAME }}/chainspec.json'
         # yamllint enable rule:line-length
 
       - name: Stop and purge db Devnet
@@ -114,18 +113,18 @@ jobs:
           kubectl delete pvc -l app=aleph-node-validator -n devnet --ignore-not-found=true
 
       - name: Start Devnet
+        # yamllint disable rule:line-length
         env:
-          RELEASE_TAG: ${{ steps.vars.outputs.sha_short }}
+          IMAGE_PLACEHOLDER: ${{ vars.ECR_PUBLIC_REGISTRY }}aleph-node:${{ steps.vars.outputs.sha_short }}
         run: |
           #!/bin/bash
-          export image_placeholder=${{ vars.ECR_PUBLIC_REGISTRY }}aleph-node:${RELEASE_TAG}
-
-          cd ${{ secrets.REPO_ARGOCD_APPS_NAME }}/aleph-node-validators/overlays/devnet/eu-central-1
+          cd '${{ secrets.REPO_ARGOCD_APPS_NAME }}/aleph-node-validators/overlays/devnet/eu-central-1'
           kustomize edit set image \
-            "aleph-node-validator-image-placeholder=${image_placeholder}"
+            'aleph-node-validator-image-placeholder=${{ env.IMAGE_PLACEHOLDER }}'
           kustomize build . | kubectl apply -f -
           sleep 2
           kubectl rollout status --watch --timeout=3600s statefulset/aleph-node-validator -n devnet
+        # yamllint enable rule:line-length
 
       - name: Waiting 5 minutes for validators to boot
         run: |
@@ -139,7 +138,7 @@ jobs:
           author_email: ${{ secrets.AUTOCOMMIT_EMAIL }}
           message: "Update Devnet docker image tag to: ${{ steps.vars.outputs.sha_short }}"
           add: "*.yaml"
-          cwd: "${{ secrets.REPO_ARGOCD_APPS_NAME }}"
+          cwd: ${{ secrets.REPO_ARGOCD_APPS_NAME }}
 
   slack:
     name: Slack notification

diff --git a/.github/workflows/deploy-to-mainnet.yml b/.github/workflows/deploy-to-mainnet.yml
@@ -43,8 +43,8 @@ jobs:
         if: inputs.force != true
         shell: bash
         run: |
-          testnet_sha=${{ steps.get-testnet-node-commit-sha.outputs.sha }}
-          current_sha=${{ steps.get-ref-properties.outputs.sha }}
+          testnet_sha='${{ steps.get-testnet-node-commit-sha.outputs.sha }}'
+          current_sha='${{ steps.get-ref-properties.outputs.sha }}'
           if [[ "${testnet_sha}" != "${current_sha}" ]]; then
             echo "Error: Testnet RPC system.version sha ${testnet_sha} is different from the"
             echo "node you're trying to deploy: ${current_sha}. If you know what you're doing"
@@ -81,8 +81,8 @@ jobs:
           target-image: ${{ steps.get-docker-image-names.outputs.dockerhub-mainnet-image }}
           additional-image:
             ${{ steps.get-docker-image-names.outputs.dockerhub-mainnet-latest-image }}
-          dockerhub-username: "${{ secrets.DOCKERHUB_USERNAME }}"
-          dockerhub-password: "${{ secrets.DOCKERHUB_PASSWORD }}"
+          dockerhub-username: ${{ secrets.DOCKERHUB_USERNAME }}
+          dockerhub-password: ${{ secrets.DOCKERHUB_PASSWORD }}
 
   slack:
     name: Slack notification

diff --git a/.github/workflows/deploy-to-testnet.yml b/.github/workflows/deploy-to-testnet.yml
@@ -44,8 +44,8 @@ jobs:
           target-image: ${{ steps.get-docker-image-names.outputs.dockerhub-testnet-image }}
           additional-image:
             ${{ steps.get-docker-image-names.outputs.dockerhub-testnet-latest-image }}
-          dockerhub-username: "${{ secrets.DOCKERHUB_USERNAME }}"
-          dockerhub-password: "${{ secrets.DOCKERHUB_PASSWORD }}"
+          dockerhub-username: ${{ secrets.DOCKERHUB_USERNAME }}
+          dockerhub-password: ${{ secrets.DOCKERHUB_PASSWORD }}
 
   slack:
     name: Slack notification

diff --git a/.github/workflows/featurenet-create-from-branch.yml b/.github/workflows/featurenet-create-from-branch.yml
@@ -62,10 +62,10 @@ jobs:
         # yamllint disable rule:line-length
         run: |
           if [[
-          ! "${{ inputs.featurenet-name }}" =~ ^[a-z0-9][a-z0-9\-]{4,48}$
+          ! '${{ inputs.featurenet-name }}' =~ ^[a-z0-9][a-z0-9\-]{4,48}$
           ]]
           then
-            echo "!!! Invalid featurenet name"
+            echo '!!! Invalid featurenet name'
             exit 1
           fi
         # yamllint enable rule:line-length