A0-1846: Removed migrations from release-11 branch #1324
Conversation
Marcin-Radecki
changed the title
Marcin-Radecki
requested review from
kostekIV,
DamianStraszak and
h4nsu
and removed request for
DamianStraszak
pallets/elections/src/migration.rs
Outdated
| #[cfg(feature = "try-runtime")] | ||
| use {frame_support::ensure, pallets_support::ensure_storage_version, sp_std::vec::Vec}; | ||
|
|
||
| use crate::{CommitteeSize, Config, NextEraCommitteeSize, Pallet, LOG_TARGET}; |
There was a problem hiding this comment.
I don't think we should remove migrations from our code. We should just detach them from the runtime...
There was a problem hiding this comment.
That also I thought, yet I don't see now in aleph-node repo any other migrations, hance I thought to follow that rule and remove them. Let me check what substrate does with that
There was a problem hiding this comment.
Yes, the reason is we had this pallet hook based migrations before, which were removed to clean things up. But it seems the convention is to keep migrations, and just attach them when needed.
There was a problem hiding this comment.
I have removed them quite some time ago. We have them in the git history if they will be ever needed (?). I have removed them because maintaining the old migrations is kinda meaningless and makes it harder to develop pallets.
There was a problem hiding this comment.
Actually, in Substrate they indeed keep migrations. I'll will bring them back then
True, will revert |
Marcin-Radecki
force-pushed
the
remove-migrations
branch
from
016bf76
to
84c5df0
Compare
Description
Remove migrations that were introduced in
r-11.3release.