-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A0-2730: bump subxt to 0.28 #1335
A0-2730: bump subxt to 0.28 #1335
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some problems related to the change of AccountId from substrate one. Pls do:
- substitute type for substrate one (you may need to use Static
- update readme for codegen cmd to include this
- In public API return AccountId not Static
Switched to substrate's |
9001200
Description
Bump subxt from 0.25 to 0.28.0 (Changelog).
Subxt is slowly removing the dependency on substrate (making it optional) in order to reduce wasm build size, so there are some breaking changes. Most importantly, a
suxbt::utils::AccountId32
type is introduced, which is basically a strippedsp_runtime::AccountId32
.[EDIT 1] We've decided to continue using substrate's AccountId, so in subxt codegen, we had to substitute subxt::utils::AccountId into that type. Unfortunately, this means that we have to wrap it into
subxt::utils::Static<>
. Higher level code, outsidealeph_zero.rs
can, and is returning plain unwrapped AccountId. Subxt also introducedsuxbt::utils::MultiAddress
in place ofsp_runtime::MultiAddress
, but currently switching to the former for us is not causing any compilation errors, so we should be safe to use it.Version 0.28 is the highest compatible with our substrate's version (next one uses newer
wasmtime
).I've run only unit and e2e tests in aleph-node - please let me know if I need to test something else (ui, manual etc).
Type of change
Please delete options that are not relevant.
Checklist: