-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A0-2998: Put 'true' in double quote in one the conditions to check if that helps #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
Aug 11, 2023
CezaryKierzyk
approved these changes
Aug 11, 2023
timorl
approved these changes
Aug 11, 2023
ggawryal
approved these changes
Aug 11, 2023
ghost
enabled auto-merge
August 11, 2023 10:52
ghost
added this pull request to the merge queue
Aug 11, 2023
ghost
deleted the
A0-2998-fix-to-secrets-being-checked-on-forks
branch
August 11, 2023 11:29
Marcin-Radecki
added a commit
to Marcin-Radecki/aleph-node
that referenced
this pull request
Aug 16, 2023
…check if that helps (Cardinal-Cryptography#1346)" This reverts commit c271f49.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Even though input as a boolean, its value in condition is cast to string.