Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A0-2998: Put 'true' in double quote in one the conditions to check if that helps #1346

Merged
11 commits merged into from
Aug 11, 2023

Conversation

ghost
Copy link

@ghost ghost commented Aug 11, 2023

Description

Even though input as a boolean, its value in condition is cast to string.

@ghost ghost self-assigned this Aug 11, 2023
.github/workflows/_check-vars-and-secrets.yml Outdated Show resolved Hide resolved
@ghost ghost enabled auto-merge August 11, 2023 10:52
@ghost ghost added this pull request to the merge queue Aug 11, 2023
Merged via the queue into main with commit c271f49 Aug 11, 2023
48 checks passed
@ghost ghost deleted the A0-2998-fix-to-secrets-being-checked-on-forks branch August 11, 2023 11:29
Marcin-Radecki added a commit to Marcin-Radecki/aleph-node that referenced this pull request Aug 16, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants