Disable button integration tests #1355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this remove TheButton e2e tests entirely from the CI? i.e. they will not run on "merge to main" nor when triggered with a label? |
Now that the button is deployed, these are just causing noise when they flake out. In the future, we probably should archive all of the button code into a separate repo.
obrok
force-pushed
the
obrok/disable-button-integration-tests
branch
from
efa4710
to
2771ba4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that the button is deployed, these are just causing noise when they flake out. In the future, we probably should archive all of the button code into a separate repo.
Type of change