-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A0-3094: Validators network details rpc call #1447
Merged
ggawryal
merged 30 commits into
Cardinal-Cryptography:main
from
ggawryal:a0-3094-validators-network-details-rpc
Nov 9, 2023
Merged
A0-3094: Validators network details rpc call #1447
ggawryal
merged 30 commits into
Cardinal-Cryptography:main
from
ggawryal:a0-3094-validators-network-details-rpc
Nov 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DamianStraszak
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
kostekIV
reviewed
Oct 20, 2023
ggawryal
changed the title
A0-3094: Validators network details rpc call
[Splitting to 2 prs] A0-3094: Validators network details rpc call
Oct 20, 2023
ggawryal
changed the title
[Splitting to 2 prs] A0-3094: Validators network details rpc call
[Splitting to 2 prs,will be rebased onto #1449] A0-3094: Validators network details rpc call
Oct 20, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 25, 2023
# Description Adding structures that will be later helpful to construct RPC call to get network details of validators. This is a part 2/3 of the whole task, see #1447). This only pulls and caches network data that was previously observed by a node, without modifying or adding any new information flow between nodes in the network. Follow up to #1448 ## Type of change Please delete options that are not relevant. - New feature (non-breaking change which adds functionality) # Checklist: <!-- delete when not applicable to your PR --> - I have added tests - I have created new documentation
ggawryal
changed the title
[Splitting to 2 prs,will be rebased onto #1449] A0-3094: Validators network details rpc call
A0-3094: Validators network details rpc call
Oct 25, 2023
kostekIV
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gj
Merged
via the queue into
Cardinal-Cryptography:main
with commit Nov 9, 2023
97bc9cf
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding an RPC call to get network details of validators. This only pulls and caches network data that was previously observed by a node, without modifying or adding any new information flow between nodes in the network.
Related PRs: #1448 #1449
RPC query output on local network
curl -H "Content-Type: application/json" -d '{"id":1, "jsonrpc":"2.0", "method": "alephNode_unstable_validatorNetworkInfo", "params": []}' http://localhost:9948/
Has been run also on testnet, slowly collects network details for authorities in each session (without
AccountId
because of the old runtime version).Type of change
Please delete options that are not relevant.
Checklist: