Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A0-3390: Prepare for proposal compatibility #1460

Merged
merged 6 commits into from
Nov 6, 2023

Conversation

timorleph
Copy link
Contributor

Description

Split data_io into two parts in a way which will make changing the type of proposals much simpler. This is mostly moving/copying files (legacy is essentially a copy of data_io), but some small additional refactors also happened to make this simpler and the change less invasive.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have made corresponding changes to the existing documentation
  • I have created new documentation

Copy link
Contributor

@lesniak43 lesniak43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing changed, good job!

Copy link
Contributor

@kostekIV kostekIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

finality-aleph/src/data_io/mod.rs Outdated Show resolved Hide resolved
finality-aleph/src/party/manager/task.rs Show resolved Hide resolved
@timorleph timorleph added this pull request to the merge queue Nov 6, 2023
Merged via the queue into Cardinal-Cryptography:main with commit cb5bbea Nov 6, 2023
9 checks passed
@timorleph timorleph deleted the A0-3390-kozoun branch November 6, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants