-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A0-3432: run_nodes.sh revamp, in particular run bootnode as RPC node #1472
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, I like the idea of keeping that script well-documented and user-friendly as a first contact point with the repo. Left minor comments.
Also, maybe @fixxxedpoint will know more context, there was some issue why we disabled purging backups by default (A0-2846). Nevertheless, I think we should be good unless user does something very strange.
backup folders affected by the current script run.
functions. This does not have an affect in this script since iteration over a string delimated by a space works the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done!
Description
This PR revamps
scripts/run_nodes.sh
so thataleph-node
, bootstraps chain, purges db, removes AlephBFT backups. User can opt-out from either of these, but obviously some of them must be present if others are etc, so the script checks all thatto chain bootstrap in general
jq
is now needed, though is not hard blocker for me to revert to previous behaviour, now it is just cleaner in bash to parse output ofaleph-node key inspect
/tmp/
to local./run-nodes-sh
, this is because the user must have write permissions in the repo he or she just cloned, and it's better to have a base path that is not shared with any other files/dirs.docker/docker_entrypoint.sh
; they are indeed duplicated now but it does not make sense to extract them to common .sh as at some pointrun_nodes.sh
might become obsolete due to dockerizationType of change
Please delete options that are not relevant.