A0-3143: Major sync test does not use pre-baked workdir. #1481
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes pre-baked
workdir
file used in major sync test. Motivations are:workdir
was generated on 11.X version. It has happened on themain
branch in which there was a change that changed database schema in a way that finalization does not work. This test is supposed to validate whether node is able to sync in major sync mode, ie when gap is greater then 2 sessions, and not major update scenario which it does nowworkdir
contributes to 20% of wholealeph-node
size and it bloats git historyworkdir
every time such breaking change occurrs, after this PR is merge we won't have to do itAlso, this PR removes some tech debt which is:
Type of change
Please delete options that are not relevant.
Testing