A0-3550: Better constants for libp2p message sizes #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesniak43
approved these changes
Nov 27, 2023
fixxxedpoint
approved these changes
Nov 27, 2023
Merged
via the queue into
Cardinal-Cryptography:main
with commit Nov 27, 2023
9055e42
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sync messages can be bigger, so increased the constant for them. Also moved some code around to lower the likelyhood of making this code in the future.
I also found some old compatibility code while going through this, so I removed in on the way, it's definitely not needed any more.
Type of change
Checklist: