-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A0-4231: Extract chain bootstrap to a separate crate #1699
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marcin-Radecki
changed the title
A0 4231 move chainspec generation
A0-4231: Extract chain bootstrap to a separate crate
Apr 23, 2024
ggawryal
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rust code looks good, workflows as far as I'm understanding too. Good job!
mikolajgs
approved these changes
Apr 26, 2024
timorleph
reviewed
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This final PR achieves the goal of removing the
aleph-runtime
dependency fromaleph-node
. A new cratechain-bootstraper
is made from the current chain bootstrap logic inaleph-node
.The dependencies in
aleph-node
should be clearer now:aleph-node
does not compile native runtime anymore via default features build.chain-bootstrapper
does compile both native and wasm runtime during build.The amount of packages that node compiles is about 150 less than it was before. Depending on the machine, It's up to 40% compilation speedup for a
aleph-node
binary. Here's local build, clean repo, on my laptop:After change -
aleph-node
andchain-bootstrapper
builds in the similar time.Before change - note though the overall time is faster than before:
This is because of
polkadot-sdk
crates architecture - we still need to compile most of the crates in both node and bootstrapper. There's small optimization in this PR to not build three polkadot-sdk crates with default features, ie to disablerocks-db
build whenchain-bootstrapper
is built.In Ci though, compilation should be faster as we can parallelize
aleph-node
andchain-bootstrapper
build, which this PR achieves so. Most of the changes are workflows anyway.Type of change
Please delete options that are not relevant.
Checklist:
main
.main
.