Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A0-4289: Rewrite Gossip #1705

Merged
merged 8 commits into from
Apr 29, 2024
Merged

A0-4289: Rewrite Gossip #1705

merged 8 commits into from
Apr 29, 2024

Conversation

lesniak43
Copy link
Contributor

Description

Replacing gossip service with SyncNetworkService and NotificationService which are responsible for managing new connections and sending data respectively. Now every protocol will be handled by a separate NotificationService, thus making our gossip code obsolete.

Type of change

  • Refactor

kostekIV
kostekIV reviewed Apr 29, 2024
View reviewed changes
Copy link
Contributor

@kostekIV kostekIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this mostly deletion with some ctr+c +ctrl+v? Where is an interesting part to look at?

bin/node/src/service.rs Outdated Show resolved Hide resolved
finality-aleph/src/network/substrate.rs Outdated Show resolved Hide resolved
timorleph
timorleph requested changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@timorleph timorleph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, but still found some ways to complain. ;>

bin/node/src/service.rs Outdated Show resolved Hide resolved
finality-aleph/src/network/substrate.rs Outdated Show resolved Hide resolved
finality-aleph/src/network/substrate.rs Outdated Show resolved Hide resolved
finality-aleph/src/network/substrate.rs Outdated Show resolved Hide resolved
finality-aleph/src/network/substrate.rs Outdated Show resolved Hide resolved
finality-aleph/src/network/substrate.rs Show resolved Hide resolved
finality-aleph/src/network/substrate.rs Outdated Show resolved Hide resolved
finality-aleph/src/network/substrate.rs Show resolved Hide resolved
finality-aleph/src/network/substrate.rs Outdated Show resolved Hide resolved
kostekIV
kostekIV reviewed Apr 29, 2024
View reviewed changes
finality-aleph/src/nodes.rs Outdated Show resolved Hide resolved
finality-aleph/src/network/substrate.rs Outdated Show resolved Hide resolved
finality-aleph/src/network/substrate.rs Show resolved Hide resolved
finality-aleph/src/network/substrate.rs Outdated Show resolved Hide resolved
timorleph
timorleph approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@timorleph timorleph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, only very minor comments left.

finality-aleph/src/lib.rs Outdated Show resolved Hide resolved
@kostekIV kostekIV added this pull request to the merge queue Apr 29, 2024
Merged via the queue into main with commit 071be6c Apr 29, 2024
12 checks passed
@kostekIV kostekIV deleted the A0-4289-rewrite-gossip branch April 29, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timorleph timorleph timorleph approved these changes

@kostekIV kostekIV kostekIV approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lesniak43 @kostekIV @timorleph