-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CW-53: Added a runtime metadata check #1762
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmikolajczyk41
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well done! lgtm
kostekIV
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a runtime metadata check, which consists of two phases:
subxt
using large self-hosted runner (1 minute)subxt codegen
on runtime built from main (used in e2e tests - short session) (1 minute)This check fails if someone forgets to regenerate the
aleph-runtime
static metadata file.There's no if condition when this check is supposed to run as if practically it does not make sense to check, e.g., if runtime code changed or aleph pallet code changed in git, as then we'd need to check every
aleph-runtime
dependency, etc. This check is lightweight (2-3 minutes, and runs in parallel with the longest check excluded packages).Also, this PR consists of changes to the
Aleph::NextAuthorities
hash. This hash is whatsubtext
thinks the hash ofNextAuthorities
metadata is. Normally, this hash does not include any of what is stored as a storage value, but only data such as pallet name, storage function name, storage value type (Option<T>
orT
), etc. Also, maybe a bit surprisingly, it includes default value of given type into thatsubxt
hash. Now,NextAuthorities
storage value type isVec<AccountId>
, and normally default isvec![]
. However, we do have a default initializerDefaultNextAuthorities
which, turns out, is used bysubxt codegen
when generating hash forNextAuthorities
. WhenDefaultNextAuthorities
, static runtime metadata generated bysubxt
is always the same in CI.DefaultNextAuthorities
is not required in pallet aleph, as initialization ofNextAuthorities
is done inon_genesis_session
.Type of change
Please delete options that are not relevant.
Testing