Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scale deps #124

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Fix scale deps #124

merged 3 commits into from
Nov 12, 2024

Conversation

JanKuczma
Copy link
Contributor

Fix scale versions across the project.

Reason: The rust version for this project is fixed to 1.72.1. scale-info has derive_more as a dependency, which in scale-info > 2.11.3 requires rust 1.75.0 or newer.

@@ -1,6 +1,6 @@
{
"source": {
"hash": "0x2321d7732d8d6402e2ba8546b78ebd718c5a090c2943076dc627f3811cbaddd5",
"hash": "0x73dc2661c0aac78ed635172b85dd14d3357dcd54d6f64659c3fc9426b9e06990",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we better keep the .json and .contract files as they are, because they are deployed in this version on-chain.

The difference is probably only because of non-determinism and some versioning issues.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can remove and ignore these files completely because the deployed versions are in the deployed directory?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but please update this line iin farms script to point to the correct artifact:

parser.add_argument('--farm-metadata', metavar='PATH', default='../../artifacts/farm_contract.json', help='path to farm contract metadata file')

@JanKuczma JanKuczma merged commit 1cdedf0 into main Nov 12, 2024
1 check passed
@JanKuczma JanKuczma deleted the fix-deps branch November 12, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants