-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release preparation #4
Conversation
7a3a0d9
to
8ed8aca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you remove the toolchain file?
Because it prevented cargo contract 3.2.0 from compiling (newer rust was needed for |
What do you need |
cargo contract uses clap, the workflow builds and installs cargo contract |
If we use the docker method I showed, you won't have that problem, as |
You mean use the docker container in CI workflow? |
Yes, why not. It's very fast. The docker image is only 300mb and could be cached but I don't think we will re-run it many times. |
I don't know how to do it straight away, and I don't think it's worth the effort of learning. The whole CI is just a |
We already do it both in common-amm and MOST. You can check it out there |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove the binary wrapped_azero.wasm
from the repo ? At least until we provide the command how to build it deterministically.
Also, we need to bring back the rust-toolchain.toml
as it might affect the final build result - ie even within the reproducible env, having different toolchains can result in different Wasm produced.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove the binary wrapped_azero.wasm
from the repo ? At least until we provide the command how to build it deterministically.
Also, we need to bring back the rust-toolchain.toml
as it might affect the final build result - ie even within the reproducible env, having different toolchains can result in different Wasm produced.
I added the .wasm file with all other compilation artifacts as PLACEHOLDERS that will be replaced with real values after the release happens. If we build it with the docker image why do we need rust-toolchain file? Isn't the environment fixed by what's inside the image? |
This PR prepares for release and deployment. See
RELEASE_TODO.md
for detailed release procedureINB4: No, changing values of constants unused by the contract does not change the WASM build outcome ;)