Return exceptions for all filesystem errors #44
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes are aimed at simplifying the Briefly API:
Briefly.create()
andBriefly.create(opts)
now return either{:ok, path}
or{:error, Exception.t()}
. The following exceptions may be returned:%Briefly.NoRootDirectoryError{}
- Returned if Briefly is unable to create a root temporary directory.%Briefly.WriteError{}
- Returned when a temporary entry cannot be created. The exception contains the POSIX error code the caused the failure.The
:too_many_attempts
error is not directly actionable so it is no longer surfaced. Since Briefly still performs several write attempts when faced with:eexist
and:eaccess
error codes, too many attempts can be inferred when either of those codes are returned.The error messages raised by
Briefly.create!()
have been moved to the Exception modules and aside from no longer printing the number of attempts they provide the same information.For example, if you have this:
...then change it to this: