Validator lookup precompilation #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a `precompile_validator_lookup` flag (defaulting to false) to `use Vex.Struct`. This changes behavior as follows: * a module attribute (@precompiled_validator_lookup) is initialized for the struct that holds a lookup data structure * calls to `validates :attribute, <validations>` proactively look up the validator AT COMPILE TIME and add them to the lookup data structure * At runtime, the expensive validator lookup is then skipped in favor of just performing a Map fetch from the precompiled validator lookup datastructure.
It is allowed to state `validates :attribute, &myfunction/1`. This special case is expanded to `validates :attribute, by: &myfunction/1` during the validation at runtime. Therefore, we need to cache the `:by` validator if we encounter a function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
precompile_validator_lookupflag (defaulting to false) touse Vex.Struct.This changes behavior as follows:
validates :attribute, <validations>proactively look up thevalidator AT COMPILE TIME and add them to the lookup data structure
validator lookup datastructure.
From my benchmarks, this improved performance on a Struct with 9 fields and 5 distinct validators from 2.25k IPS to 11.3k IPS (+361% performance).