Support SSO #366
Merged
Support SSO #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alasarr
reviewed
Jul 28, 2023
alasarr
reviewed
Jul 28, 2023
| getAccessToken(); | ||
| } else if (isAuthenticated) { | ||
| if (accountHasBeenFulfilled) { |
There was a problem hiding this comment.
Not following why you need to trust the URL to see if the user has completed the account. I think it's possible by checking the metadata only.
There was a problem hiding this comment.
Something like this is not working?
if (isAuthenticated && userMetadata) {
getAccessToken();
}
else if (isAuthenticated && !userMetadata) {
const searchParams = new URLSearchParams({
redirectUri: buildAccountFulfilledUri(),
});
// Redirect to: accounts-www for signup on cloud-native
window.location.href = `${redirectAccountUri}?${searchParams}`;
}
else {
loginWithRedirect();
}There was a problem hiding this comment.
No, to get the metadata you need to request a new token (with loginWithRedirect). As you were loged in before having the user_metadata you need to check the url and log in again.
alasarr
reviewed
Jul 28, 2023
| @@ -1,21 +1,63 @@ | |||
| import { useDispatch } from 'react-redux'; | |||
There was a problem hiding this comment.
Not for this PR, but I would like to deprecated template-base-3 for javascript
alasarr
reviewed
Jul 31, 2023
| dispatch(setCredentials({ accessToken })); | ||
| }; | ||
| if (hasForceLogin) { | ||
| // if FORCE_LOGIN_PARAM is present we have to login again |
There was a problem hiding this comment.
Suggested change
| // if FORCE_LOGIN_PARAM is present we have to login again | |
| // if FORCE_LOGIN_PARAM is set a relogin is required to refresh userMetadata |
alasarr
reviewed
Jul 31, 2023
alasarr
reviewed
Jul 31, 2023
alasarr
suggested changes
Jul 31, 2023
alasarr
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.shortcut.com/cartoteam/story/333386/cra-template-signup-with-cn
Depends on: CartoDB/carto-react#750 and https://github.com/CartoDB/cloud-native/pull/13207