Fix HistogramWidget with one non-zero bucket

CartoDB · Sep 11, 2024 · 6c97ebb · 6c97ebb
1 parent 04b9491
commit 6c97ebb
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 ## Not released
 
+- Fix HistogramWidget with one non-zero bucket [#901](https://github.com/CartoDB/carto-react/pull/901)
 - Spatial Index Sources use remote widgets calculation [#898](https://github.com/CartoDB/carto-react/pull/898)
 - Support for `hiddenColumnFields` parameter and `onRowClick` handler for Table Widget [#900](https://github.com/CartoDB/carto-react/pull/900)
 

diff --git a/packages/react-ui/src/widgets/HistogramWidgetUI/HistogramWidgetUI.js b/packages/react-ui/src/widgets/HistogramWidgetUI/HistogramWidgetUI.js
@@ -195,7 +195,8 @@ function HistogramWidgetUI({
   // Series
   const seriesOptions = useMemo(() => {
     // We check if we have just one different value
-    const isUniqueDataRow = formattedData.filter((row) => row[2] !== 0).length === 1;
+    const isUniqueDataRow =
+      min === max && formattedData.filter((row) => row[2] !== 0).length === 1;
 
     const data = isUniqueDataRow
       ? [formattedData[0], formattedData[formattedData.length - 1]]

diff --git a/packages/react-ui/storybook/stories/widgetsUI/HistogramWidgetUI.stories.js b/packages/react-ui/storybook/stories/widgetsUI/HistogramWidgetUI.stories.js
@@ -93,3 +93,22 @@ const LoadingProps = {
   isLoading: true
 };
 Loading.args = LoadingProps;
+
+export const OneNonZeroBinMid = LoadingTemplate.bind({});
+OneNonZeroBinMid.args = {
+  ...defaultProps,
+  data: [0, 300, 0, 0, 0, 0, 0]
+};
+
+export const OneNonZeroBinStart = LoadingTemplate.bind({});
+OneNonZeroBinStart.args = {
+  ...defaultProps,
+  data: [100, 0, 0, 0, 0, 0, 0]
+};
+
+
+export const OneNonZeroBinEnd = LoadingTemplate.bind({});
+OneNonZeroBinEnd.args = {
+  ...defaultProps,
+  data: [0, 0, 0, 0, 0, 0, 100]
+};