Improve responsive behavior of MenuItem (#753)

CartoDB · Jul 28, 2023 · a49c06d · a49c06d
1 parent d287f24
commit a49c06d
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 ## Not released
 
+- Improve responsive behavior of MenuItem [#753](https://github.com/CartoDB/carto-react/pull/753)
 - Increase documentation discoverability [#751](https://github.com/CartoDB/carto-react/pull/751)
 
 ## 2.2

diff --git a/packages/react-ui/src/theme/sections/components/navigation.js b/packages/react-ui/src/theme/sections/components/navigation.js
@@ -10,6 +10,12 @@ export const navigationOverrides = {
         height: theme.spacing(4),
         transition: 'background-color 300ms cubic-bezier(0.4, 0, 0.2, 1) 0ms',
 
+        [theme.breakpoints.up('sm')]: {
+          // Overrides an unwanted Mui default style
+          '&.MuiButtonBase-root': {
+            minHeight: theme.spacing(4)
+          }
+        },
         '&:focus-visible': {
           // Solves a known Mui issue: https://github.com/mui/material-ui/issues/23747
           backgroundColor: 'transparent',
@@ -42,7 +48,14 @@ export const navigationOverrides = {
       }),
       dense: ({ theme }) => ({
         minHeight: theme.spacing(3),
-        height: theme.spacing(3)
+        height: theme.spacing(3),
+
+        [theme.breakpoints.up('sm')]: {
+          // Overrides an unwanted Mui default style
+          '&.MuiButtonBase-root': {
+            minHeight: theme.spacing(3)
+          }
+        }
       })
     }
   },