Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LegendWidget update logic for multiple legends case #889

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

juandjara
Copy link
Contributor

Description

Shortcut: https://app.shortcut.com/geographica/story/425245

Fix react-redux action updateLayer to account for the case of multiple legend objects per layer, keeping array object reference.

Type of change

  • Fix

Acceptance

Please describe how to validate the feature or fix

  1. Render a in which one layer has multiple legends
  2. Collapse or hide one of those legends
  3. Uncollapse or show the same legend
  4. It should be back to its original state

This feature is not used in cloud-native but it is used in various PS projects such as Groupauto, DHL, and more

Basic checklist

  • Good PR name
  • Shortcut link
  • Changelog entry
  • Just one issue per PR
  • GitHub labels
  • Proper status & reviewers
  • Tests
  • Documentation

@juandjara juandjara requested a review from padawannn July 19, 2024 10:58
Copy link

github-actions bot commented Jul 19, 2024

Pull Request Test Coverage Report for Build 10006952761

Details

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 71.194%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-redux/src/slices/cartoSlice.js 2 3 66.67%
Totals Coverage Status
Change from base Build 9805322941: -0.004%
Covered Lines: 2816
Relevant Lines: 3642

💛 - Coveralls

Copy link

github-actions bot commented Jul 19, 2024

Visit the preview URL for this PR (updated for commit 8bc630a):

https://cartodb-fb-storybook-react-dev--pr889-fix-legend-widge-8371ldbn.web.app

(expires Fri, 26 Jul 2024 11:04:45 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c

@padawannn padawannn merged commit 48a293a into master Jul 22, 2024
2 checks passed
@padawannn padawannn deleted the fix/legend-widget-data branch July 22, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants