Handle BigInt numbers from API #920
Conversation
| "extends": "react-app" | ||
| "extends": "react-app", | ||
| "env": { | ||
| "es2020": true |
There was a problem hiding this comment.
Otherwise, BigInt constructor gives an ESLint error 🤦
Pull Request Test Coverage Report for Build 11275100558Details
💛 - Coveralls |
|
Visit the preview URL for this PR (updated for commit 6a75fc4): https://cartodb-fb-storybook-react-dev--pr920-bug-445700-handl-zhncxf6c.web.app (expires Thu, 17 Oct 2024 13:36:48 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c |
|
|
||
| const res = await getStats({ source: QUERY_SOURCE, column: 'injuries' }); | ||
|
|
||
| expect(res.rows[0].quadbin).toEqual(BigInt(5256683984082960383)); |
There was a problem hiding this comment.
Careful here! Writing this out as BigInt(5256683984082960383) will truncate the number before it's passed to the BigInt function, so these are not equal, note the n suffix:
BigInt(5256683984082960383) === BigInt(5256683984082960383n) // false!| const bigIntReviver = (key, value) => { | ||
| if (typeof value === 'number' && value > Number.MAX_SAFE_INTEGER) { | ||
| return BigInt(value); | ||
| } | ||
| return value; | ||
| }; |
There was a problem hiding this comment.
See above — unfortunately I think that it's necessary to receive the value as a string and not an integer. By the time the reviver receives a numeric value, I think it will be too late to recover the original integer.
Possible solution in https://stackoverflow.com/a/69644630, though maybe this is complex enough that we want a dependency to help...
Description
https://app.shortcut.com/cartoteam/story/445700/handle-bigint-numbers-coming-from-the-api-properly-in-carto-react?vc_group_by=day&ct_workflow=all&cf_workflow=500193639
Type of change