Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Showing "Browse subgenres" folder coming from "Previous page" #1661

Merged
merged 1 commit into from
Dec 31, 2023

Conversation

Falke-Design
Copy link
Contributor

Check if this PR fulfills these requirements:

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Feature change (non-breaking change which changes behaviour of an existing functionality)
  • Improvement (non-breaking change which improves functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactor (non-breaking performance or readability improvements)

Description

Fixes: #1660

"Browse Subgenres" folder was not available if the first page was opened over "Previous page".
The subgenres_id was not passed to the next page, so it was not possible to re-create the "Subgenres" folder after clicking "Previous page".
Now the subgenres_id is always passed but the folder "Browse Subgenres" is only on the first page visible. The first page is detected over 'previous_start' not in video_list.perpetual_range_selector

In case of Feature change / Breaking change:

Describe the current behavior

Describe the new behavior

Screenshots (if appropriate):

Before:
kodi_subgenres

Copy link
Owner

@CastagnaIT CastagnaIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has sense, thank you

@CastagnaIT CastagnaIT merged commit cea708a into CastagnaIT:master Dec 31, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Browse Subgenres" is not added if the first page is opened over "Previous page"
2 participants