Download the search result as a file in a selected format #2581
Conversation
| @@ -101,6 +101,11 @@ public Long getId() { | |||
| public DatasetFieldType getDatasetFieldType() { | |||
| return datasetFieldType; | |||
| } | |||
|
|
|||
| public boolean isOfType(final DatasetFieldType type) { | |||
|
|
|||
There was a problem hiding this comment.
This empty line do not fit Dataverse coding style. Should be removed.
| @@ -110,6 +110,8 @@ public class DatasetFieldType implements Serializable, Comparable<DatasetFieldTy | |||
| private int displayOrder; | |||
|
|
|||
| private String displayFormat; | |||
|
|
|||
| private boolean exportToFile = false; | |||
There was a problem hiding this comment.
Redundant assignment as false is be default.
|
|
||
|
|
||
| public boolean isExportToFile() { | ||
|
|
There was a problem hiding this comment.
Empty line do not fit overall code style. Please remove it.
| @@ -506,6 +514,11 @@ public void setRequiredInDataverse(boolean requiredInDataverse) { | |||
| public void setDisplayFormat(String displayFormat) { | |||
| this.displayFormat = displayFormat; | |||
| } | |||
|
|
|||
| public void setExportToFile(final boolean exportToFile) { | |||
|
|
|||
There was a problem hiding this comment.
Empty line, as above's. Please remove it.
| @@ -205,6 +205,18 @@ public List<DatasetField> getDatasetFields() { | |||
| public List<DatasetField> getDatasetFieldsOptional() { | |||
| return datasetFieldsOptional; | |||
| } | |||
|
|
|||
| public List<DatasetField> getDatasetFieldsAll() { | |||
|
|
|||
| solrSearchResultsService.populateDatafileSearchCard( | ||
| results.getOrDefault(SearchObjectType.FILES, Collections.emptyList())); |
There was a problem hiding this comment.
Please revert such changes, as they do not bring valuable think.
| if (sortOrderSupplied.equals(SortOrder.desc.toString())) { | ||
| this.sortOrder = SortOrder.desc; | ||
| } | ||
| public void setSortOrder(final String sortOrderSupplied) { |
There was a problem hiding this comment.
Seems that it not change much. I would revert it, as it not add a value, and make tracking changes harder.
| @@ -24,6 +24,8 @@ | |||
| <ui:param name="showDataverseHeader" value="false"/> | |||
| <ui:define name="body"> | |||
| <h:form id="dashboardMaximumEmbargoForm" onkeypress="return event.keyCode != 13"> | |||
|
|
|||
| <h1>eksport wyników wyszukiwania</h1> | |||
There was a problem hiding this comment.
Why it is preceded with empty line? Please remove it.
Why it is in Polish language? Why not translation mechanism applied here?
| @@ -198,7 +198,19 @@ | |||
| </div> | |||
| </div> | |||
| </div> | |||
|
|
|||
| <!-- Export search results --> | |||
| @MockitoSettings(strictness = LENIENT) | ||
| public class DashboardExportSearchResultsPageTest { | ||
|
|
||
| private DashboardExportSearchResultsPage page; |
There was a problem hiding this comment.
Why not @Injectmocks if You use already @mock. It is kind of mixed approach.
No description provided.