RunCellpose via docker #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! One comment from me
I don't think so, Docker versioning SHOULD take care of that. |
bethac07
reviewed
Jun 15, 2023
bethac07
reviewed
Jun 15, 2023
bethac07
reviewed
Jun 15, 2023
bethac07
reviewed
Jun 16, 2023
bethac07
approved these changes
Aug 4, 2023
active_plugins/runcellpose.py
Outdated
| @@ -659,6 +659,6 @@ def upgrade_settings(self, setting_values, variable_revision_number, module_name | |||
| setting_values = setting_values + ["0.0", False, "15", "1.0", False, False] | |||
| variable_revision_number = 3 | |||
| if variable_revision_number == 3: | |||
| setting_values = ["Python"] | |||
| setting_values = setting_values[0] + ["Python"] + setting_values[1:] | |||
DavidStirling
pushed a commit
to DavidStirling/CellProfiler-plugins
that referenced
this pull request
Sep 25, 2023
* adding docker subprocess option to RunCellpose * Dockerfile and associated script for building RunCellpose docker * add docker documentation * better docs since docker image is automatically downloaded when requested * upgrade module version * fix upgrade settings * docs for using docker * Add model to upgrade_settings * Typo * Fix upgrade_settings fixier --------- Co-authored-by: Erin Weisbart <[email protected]> Co-authored-by: Beth Cimini <[email protected]> Co-authored-by: bethac07 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the RunCellpose model that's been adapted to work with docker.
This version of the module allows users to use Cellpose using the .exe/.app downloaded from the CellProfiler website. All a user would have to do is download and install docker, followed by downloading the
cellprofiler/runcellpose_no_pretrainedorcellprofiler/runcellpose_with_pretraineddocker images and setting the plugins directory in CellProfiler > Preferences. These different docker images either contain or don't contain all of the Cellpose pretrained modelsOutstanding questions:
cellprofiler/runcellpose_no_pretrained:0.1andcellprofiler/runcellpose_with_pretrained:0.1are built on the pytorch CUDA docker image and as a result are pretty beefy (12GB on disk for me). Since some users may not have a CUDA GPU, it might make sense to create a slim CPU version and allow users to select this from the GUI dropdown.--gpus allhandles thisdocker_pathwork across different machines? How consistent is docker path? What is the docker path on linux?variable_revision_numberbe linked to a particular version of a docker image? Hopefully this would ensure compatibility