Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an EnforceObjectsOneToOne plugin [WIP] #242

Merged
merged 16 commits into from
Sep 11, 2024
Merged

Conversation

bethac07
Copy link
Member

@bethac07 bethac07 commented Apr 4, 2024

Replaces #238

We initially looked at putting this functionality into RunCellpose (#227), and a lot of the pseudocode happened there, but in writing this up I realized that a) it was fiddly and b) the more DL segmentation stuff we add, the more we were going to need it, and so I extracted it out into its own module. Initial draft here lacks a display and some documentation but otherwise as far as I can tell is otherwise functional and is creating the correct outputs.

@bethac07
Copy link
Member Author

bethac07 commented Apr 4, 2024

@sugan89 identified a case where this is failing, will dig in later but I now have the files to do so

@bethac07
Copy link
Member Author

bethac07 commented Apr 4, 2024

image

@ErinWeisbart
Copy link
Member

Would like to have the third panel of the display image be outlines of the enforced primary and secondary objects superimposed but I don't understand how to make that work so I need help.

Do we ever have module inputs that are only for the display? Because it would be neat to add the functionality of Do you want to see enforced objects superimposed on an image? and then Select image and then having that as the background of the outline image as it would be much easier to see if your new enforced objects make biological sense (without having to use the Workspace Viewer).

@bethac07
Copy link
Member Author

Would like to have the third panel of the display image be outlines of the enforced primary and secondary objects superimposed but I don't understand how to make that work so I need help.

IDSecondary has something like that, perhaps that code will be of use?

Do we ever have module inputs that are only for the display? Because it would be neat to add the functionality of Do you want to see enforced objects superimposed on an image? and then Select image and then having that as the background of the outline image as it would be much easier to see if your new enforced objects make biological sense (without having to use the Workspace Viewer).

Oh @ErinWeisbart , the answer to "do we ever do X in CellProfiler" is ALWAYS yes. In this case, the "display local maxima" setting in IDPrimary

@ErinWeisbart
Copy link
Member

I still don't understand how, but I did it :)
AFAIK this is ready to merge (other than @bethac07 's outstanding comment above about comments being out of order)

@bethac07 bethac07 marked this pull request as ready for review September 11, 2024 07:13
@bethac07
Copy link
Member Author

I confess I found some of the descriptions over-mathy, to the point in one or two places I couldn't parse correctness, so I did a small editing pass. If you can live with @ErinWeisbart , please do pull, otherwise, edit as you see fit and then pull!

@ErinWeisbart ErinWeisbart merged commit 6e07086 into master Sep 11, 2024
0 of 3 checks passed
@ErinWeisbart ErinWeisbart deleted the enforce_one_to_one branch November 14, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants