Feat/user leave #31
Open
Feat/user leave #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danden1
reviewed
Oct 17, 2024
|
|
||
| Mono<Boolean> findMakerPendingReservation(Long makerId); | ||
|
|
||
| Mono<Boolean> findUserPendingReservation(Long makerId); |
There was a problem hiding this comment.
이 부분 parameter 이름이 makerId 보다는 userId 가 더 어울리는 것 같습니다!
Mono<Boolean> findUserPendingReservation(Long userId);
이면 좋을 것 같습니다!
There was a problem hiding this comment.
이 부분은 코틀린으로 옮긴 후에 수정해도 좋을 것 같습니다.
There was a problem hiding this comment.
오 제가 잘못 적었네요ㅠ 넵넵 코틀린 수정시에 반영해두겠습니다!
Danden1
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
회원 탈퇴 로직 개선