Jwt #11
Merged
Jwt #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elena-Bruyako
suggested changes
Sep 22, 2024
| auth -> auth | ||
| .requestMatchers( | ||
| "/auth/**", | ||
| "/api/auth/register", |
There was a problem hiding this comment.
Suggested change
| "/api/auth/register", |
| return userService.register(requestDto); | ||
| } | ||
|
|
||
| @PostMapping("/login") | ||
| public UserLoginResponseDto login(UserLoginRequestDto requestDto) { |
There was a problem hiding this comment.
Suggested change
| public UserLoginResponseDto login(UserLoginRequestDto requestDto) { | |
| public UserLoginResponseDto login(@RequestBody @Valid UserLoginRequestDto requestDto) { |
Comment on lines
30
to
37
| String path = request.getRequestURI(); | ||
| if ( | ||
| path.startsWith("/api/auth") | ||
| || path.startsWith("/api/swagger-ui") | ||
| || path.startsWith("/api/v3/api-docs")) { | ||
| filterChain.doFilter(request, response); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Suggested change
| String path = request.getRequestURI(); | |
| if ( | |
| path.startsWith("/api/auth") | |
| || path.startsWith("/api/swagger-ui") | |
| || path.startsWith("/api/v3/api-docs")) { | |
| filterChain.doFilter(request, response); | |
| return; | |
| } |
| } | ||
|
|
||
| private String getToken(HttpServletRequest request) { | ||
| String bearerToken = request.getHeader("Authorization"); |
There was a problem hiding this comment.
Suggested change
| String bearerToken = request.getHeader("Authorization"); | |
| String bearerToken = request.getHeader(HttpHeaders.AUTHORIZATION); |
Comment on lines
53
to
54
| if (StringUtils.hasText(bearerToken) && bearerToken.startsWith("Bearer ")) { | ||
| return bearerToken.substring(7); |
There was a problem hiding this comment.
Suggested change
| if (StringUtils.hasText(bearerToken) && bearerToken.startsWith("Bearer ")) { | |
| return bearerToken.substring(7); | |
| if (StringUtils.hasText(bearerToken) && bearerToken.startsWith(TOKEN_HEADER)) { | |
| return bearerToken.substring(TOKEN_HEADER.length()); |
create constant TOKEN_HEADER = "Bearer "
Elena-Bruyako
suggested changes
Sep 23, 2024
| @@ -31,4 +35,9 @@ public UserResponseDto register(@RequestBody @Valid UserRegistrationRequestDto r | |||
|
|
|||
| return userService.register(requestDto); | |||
| } | |||
|
|
|||
| @PostMapping("/login") | |||
Elena-Bruyako
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.