docker #16
Merged
docker #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okuzan
suggested changes
Oct 2, 2024
.env
Outdated
| @@ -0,0 +1,8 @@ | |||
| MYSQLDB_DATABASE=book_store | |||
There was a problem hiding this comment.
git rm --cached .env - .env should never be in version control, add .env.template instead with actual values removed - otherwise we would need to search for all env var throughout the project to start it
docker-compose.yml
Outdated
| "spring.datasource.password" : "$MYSQLDB_ROOT_PASSWORD", | ||
| "spring.jpa.properties.hibernate.dialect" : "org.hibernate.dialect.MySQLDialect" | ||
| }' | ||
| JAVA_TOOL_OPTIONS: "-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=*:5005" |
Elena-Bruyako
suggested changes
Oct 2, 2024
| @@ -1,8 +1,6 @@ | |||
| spring.application.name=BookStore | |||
| spring.datasource.url=jdbc:mysql://localhost/book_store?serverTimezone=UTC | |||
| spring.datasource.url=jdbc:mysql://mysqldb:3306/book_store?serverTimezone=UTC | |||
Elena-Bruyako
suggested changes
Oct 2, 2024
| @@ -1,8 +1,6 @@ | |||
| spring.application.name=BookStore | |||
| spring.datasource.url=jdbc:mysql://localhost/book_store?serverTimezone=UTC | |||
There was a problem hiding this comment.
Suggested change
| spring.datasource.url=jdbc:mysql://localhost/book_store?serverTimezone=UTC | |
| spring.datasource.url=jdbc:mysql://localhost:3306/book_store?serverTimezone=UTC |
Also, you can get properties from .env file spring.config.import=optional:file:.env[.properties]
In this case you will have like:
spring.datasource.username=${MYSQLDB_USER} etc
okuzan
suggested changes
Oct 3, 2024
.env.template
Outdated
| @@ -0,0 +1,9 @@ | |||
| MYSQLDB_USER=${MYSQLDB_USER} | |||
There was a problem hiding this comment.
this doesn't make much sense. It's kinda a recursion :) Better remove everything after = altogether
Elena-Bruyako
suggested changes
Oct 3, 2024
.env.template
Outdated
Comment on lines
3
to
9
| MYSQLDB_ROOT_PASSWORD=pass | ||
| MYSQLDB_LOCAL_PORT=port | ||
| MYSQLDB_DOCKER_PORT=port | ||
|
|
||
| SPRING_LOCAL_PORT=port | ||
| SPRING_DOCKER_PORT=port | ||
| DEBUG_PORT=port |
There was a problem hiding this comment.
Suggested change
| MYSQLDB_ROOT_PASSWORD=pass | |
| MYSQLDB_LOCAL_PORT=port | |
| MYSQLDB_DOCKER_PORT=port | |
| SPRING_LOCAL_PORT=port | |
| SPRING_DOCKER_PORT=port | |
| DEBUG_PORT=port | |
| MYSQLDB_ROOT_PASSWORD= | |
| MYSQLDB_LOCAL_PORT= | |
| MYSQLDB_DOCKER_PORT= | |
| SPRING_LOCAL_PORT= | |
| SPRING_DOCKER_PORT= | |
| DEBUG_PORT= |
.env.template
Outdated
| @@ -0,0 +1,9 @@ | |||
| MYSQLDB_USER=user | |||
| MYSQLDB_DATABASE=db | |||
There was a problem hiding this comment.
Suggested change
| MYSQLDB_DATABASE=db | |
| MYSQLDB_DATABASE= |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.