Hw add global exception handler #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
validation annotations added to CreateBookRequestDto
Elena-Bruyako
suggested changes
Sep 11, 2024
| private String author; | ||
| @NotNull |
There was a problem hiding this comment.
Suggested change
| @NotNull | |
| @NotBlank |
| .map(this::getErrorMessage) | ||
| .toList(); | ||
| body.put("error", errors); | ||
| return new ResponseEntity<>(body, headers, status); |
There was a problem hiding this comment.
Suggested change
| return new ResponseEntity<>(body, headers, status); | |
| return new ResponseEntity<>(body, headers, HttpStatus.BAD_REQUEST); |
| @Constraint(validatedBy = UniqueValidation.class) | ||
| @Target({ElementType.FIELD}) | ||
| @Retention(RetentionPolicy.RUNTIME) | ||
| public @interface Unique { |
There was a problem hiding this comment.
remove redundant validatot
you have unique constraint in Book entity
If you would like to check isbn, it's better to use regexp pattern
pattern format isbn added
Elena-Bruyako
suggested changes
Sep 11, 2024
| @@ -6,4 +6,6 @@ | |||
|
|
|||
| public interface BookRepository extends JpaRepository<Book, Long>, JpaSpecificationExecutor<Book> { | |||
|
|
|||
| boolean existsByIsbn(String isbn); | |||
|
|
||
| @ControllerAdvice | ||
| public class CustomGlobalExceptionHandler extends ResponseEntityExceptionHandler { | ||
|
|
Elena-Bruyako
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.