feat(grandpa): implement neighbor tracker and message handling #4230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimjbrettj
requested review from
EclesioMeloJunior,
timwu20 and
kishansagathiya
as code owners
jimjbrettj
force-pushed
the
jimmy/neighborMsgTracking
branch
from
6293cf3
to
0c0cbb8
Compare
jimjbrettj
changed the base branch from
jimmy/paseoBlock1789153
to
development
jimjbrettj
force-pushed
the
jimmy/neighborMsgTracking
branch
from
b51687a
to
7c17435
Compare
EclesioMeloJunior
approved these changes
Oct 8, 2024
Comment on lines
+58
to
+59
| const duration = NeighborBroadcastPeriod | ||
| ticker := time.NewTicker(duration) |
There was a problem hiding this comment.
Suggested change
| const duration = NeighborBroadcastPeriod | |
| ticker := time.NewTicker(duration) | |
| ticker := time.NewTicker(NeighborBroadcastPeriod) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds the neighbor messaging protocol. This includes the ability to handle received neighbor messages, the ability to correctly send neighbor messages, as well as tracking the state of our neighbors (that we use when deciding who to send messages too),
Tests
go test -tags integration github.com/ChainSafe/gossamerIssues
#2931