-
-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: de-duplicate payloads from persisted beacon blocks #7034
Draft
matthewkeil
wants to merge
18
commits into
unstable
Choose a base branch
from
mkeil/dedup-beacon-block-3
base: unstable
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #7034 +/- ##
============================================
+ Coverage 49.24% 49.32% +0.07%
============================================
Files 578 577 -1
Lines 37443 37369 -74
Branches 2168 2162 -6
============================================
- Hits 18440 18431 -9
+ Misses 18963 18898 -65
Partials 40 40 |
Performance Report✔️ no performance regression detected Full benchmark results
|
twoeths
reviewed
Aug 23, 2024
matthewkeil
force-pushed
the
mkeil/dedup-beacon-block-3
branch
from
August 27, 2024 05:45
46649b0
to
c893952
Compare
matthewkeil
force-pushed
the
mkeil/dedup-beacon-block-3
branch
from
September 16, 2024 07:57
d9fa635
to
dea3b7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Replace #6029
Motivation
Lodestar is saving data that is also saved in the execution client database. In particular we are persisting transactions and withdrawals in the
block
andblockArchive
databases.Description
Stores blinded blocks in both the hot and cold db. Modifies calls for data retrieval that require the full block, ReqResp and API, to splice in the missing transactions and withdrawals.